Skip to content

Commit b9a7c43

Browse files
author
Chris Brody
authored
fix Android package identifier description text (#155)
and clarify that this is a _Java_ package identifier that is _used_ by the Android module
1 parent 2b82efb commit b9a7c43

File tree

7 files changed

+8
-8
lines changed

7 files changed

+8
-8
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ Options:
9494
--prefix <prefix> The prefix for the library module (Default: ``)
9595
--module-name <moduleName> The module library package name to be used in package.json. Default: react-native-(name in param-case)
9696
--module-prefix <modulePrefix> The module prefix for the library module, ignored if --module-name is specified (Default: `react-native`)
97-
--package-identifier <packageIdentifier> (Android only!) The package name for the Android module (Default: `com.reactlibrary`)
97+
--package-identifier <packageIdentifier> [Android] The Java package identifier used by the Android module (Default: `com.reactlibrary`)
9898
--platforms <platforms> Platforms the library module will be created for - comma separated (Default: `ios,android`)
9999
--github-account <githubAccount> The github account where the library module is hosted (Default: `github_account`)
100100
--author-name <authorName> The author's name (Default: `Your Name`)
@@ -129,7 +129,7 @@ createLibraryModule({
129129
moduleName: String, /* The module library package name to be used in package.json. Default: react-native-(name in param-case) */
130130
modulePrefix: String, /* The module prefix for the library, ignored if moduleName is specified (Default: react-native) */
131131
platforms: Array | String, /* Platforms the library will be created for. (Default: ['android', 'ios']) */
132-
packageIdentifier: String, /* (Android only!) The package name for the Android module (Default: com.reactlibrary) */
132+
packageIdentifier: String, /* [Android] The Java package identifier used by the Android module (Default: com.reactlibrary) */
133133
githubAccount: String, /* The github account where the library is hosted (Default: `github_account`) */
134134
authorName: String, /* The author's name (Default: `Your Name`) */
135135
authorEmail: String, /* The author's email (Default: `[email protected]`) */

lib/cli-command.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ ${postCreateInstructions(createOptions)}`);
6969
default: 'react-native',
7070
}, {
7171
command: '--package-identifier [packageIdentifier]',
72-
description: '(Android only!) The package name for the Android module',
72+
description: '[Android] The Java package identifier used by the Android module',
7373
default: 'com.reactlibrary',
7474
}, {
7575
command: '--platforms <platforms>',

tests/integration/cli/help/__snapshots__/cli-help.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Options:
1010
--prefix [prefix] The prefix for the library module (default: \\"\\")
1111
--module-name [moduleName] The module library package name to be used in package.json. Default: react-native-(name in param-case)
1212
--module-prefix [modulePrefix] The module prefix for the library module, ignored if --module-name is specified (default: \\"react-native\\")
13-
--package-identifier [packageIdentifier] (Android only!) The package name for the Android module (default: \\"com.reactlibrary\\")
13+
--package-identifier [packageIdentifier] [Android] The Java package identifier used by the Android module (default: \\"com.reactlibrary\\")
1414
--platforms <platforms> Platforms the library module will be created for - comma separated (default: \\"ios,android\\")
1515
--github-account [githubAccount] The github account where the library module is hosted (default: \\"github_account\\")
1616
--author-name [authorName] The author's name (default: \\"Your Name\\")

tests/integration/cli/noargs/__snapshots__/cli-noargs.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Options:
1010
--prefix [prefix] The prefix for the library module (default: \\"\\")
1111
--module-name [moduleName] The module library package name to be used in package.json. Default: react-native-(name in param-case)
1212
--module-prefix [modulePrefix] The module prefix for the library module, ignored if --module-name is specified (default: \\"react-native\\")
13-
--package-identifier [packageIdentifier] (Android only!) The package name for the Android module (default: \\"com.reactlibrary\\")
13+
--package-identifier [packageIdentifier] [Android] The Java package identifier used by the Android module (default: \\"com.reactlibrary\\")
1414
--platforms <platforms> Platforms the library module will be created for - comma separated (default: \\"ios,android\\")
1515
--github-account [githubAccount] The github account where the library module is hosted (default: \\"github_account\\")
1616
--author-name [authorName] The author's name (default: \\"Your Name\\")

tests/with-injection/cli/command/object/__snapshots__/lib-cli-command-object-text.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Object {
2323
Object {
2424
"command": "--package-identifier [packageIdentifier]",
2525
"default": "com.reactlibrary",
26-
"description": "(Android only!) The package name for the Android module",
26+
"description": "[Android] The Java package identifier used by the Android module",
2727
},
2828
Object {
2929
"command": "--platforms <platforms>",

tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ Array [
5353
"option": Object {
5454
"args": Array [
5555
"--package-identifier [packageIdentifier]",
56-
"(Android only!) The package name for the Android module",
56+
"[Android] The Java package identifier used by the Android module",
5757
[Function],
5858
"com.reactlibrary",
5959
],

tests/with-mocks/cli/program/with-missing-args/__snapshots__/cli-program-with-missing-args.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Array [
5151
"option": Object {
5252
"args": Array [
5353
"--package-identifier [packageIdentifier]",
54-
"(Android only!) The package name for the Android module",
54+
"[Android] The Java package identifier used by the Android module",
5555
[Function],
5656
"com.reactlibrary",
5757
],

0 commit comments

Comments
 (0)