Skip to content

Commit 148dcbc

Browse files
committed
formatting, remove logs
1 parent 0648573 commit 148dcbc

File tree

2 files changed

+25
-33
lines changed

2 files changed

+25
-33
lines changed

stagehand/context.py

Lines changed: 18 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ async def create_stagehand_page(self, pw_page: Page) -> StagehandPage:
2828
stagehand_page = StagehandPage(pw_page, self.stagehand, self)
2929
await self.inject_custom_scripts(pw_page)
3030
self.page_map[pw_page] = stagehand_page
31-
31+
3232
# Initialize frame tracking for this page
3333
await self._attach_frame_navigated_listener(pw_page, stagehand_page)
34-
34+
3535
return stagehand_page
3636

3737
async def inject_custom_scripts(self, pw_page: Page):
@@ -78,25 +78,18 @@ def get_active_page(self) -> StagehandPage:
7878
def register_frame_id(self, frame_id: str, page: StagehandPage):
7979
"""Register a frame ID to StagehandPage mapping."""
8080
self.frame_id_map[frame_id] = page
81-
self.stagehand.logger.debug(
82-
f"Registered frame ID {frame_id} to page", category="context"
83-
)
8481

8582
def unregister_frame_id(self, frame_id: str):
8683
"""Unregister a frame ID from the mapping."""
8784
if frame_id in self.frame_id_map:
8885
del self.frame_id_map[frame_id]
89-
self.stagehand.logger.debug(
90-
f"Unregistered frame ID {frame_id}", category="context"
91-
)
9286

9387
def get_stagehand_page_by_frame_id(self, frame_id: str) -> StagehandPage:
9488
"""Get StagehandPage by frame ID."""
9589
return self.frame_id_map.get(frame_id)
9690

9791
@classmethod
9892
async def init(cls, context: BrowserContext, stagehand):
99-
stagehand.logger.debug("StagehandContext.init() called", category="context")
10093
instance = cls(context, stagehand)
10194
# Pre-initialize StagehandPages for any existing pages
10295
stagehand.logger.debug(
@@ -176,7 +169,9 @@ async def wrapped_pages():
176169
return wrapped_pages
177170
return attr
178171

179-
async def _attach_frame_navigated_listener(self, pw_page: Page, stagehand_page: StagehandPage):
172+
async def _attach_frame_navigated_listener(
173+
self, pw_page: Page, stagehand_page: StagehandPage
174+
):
180175
"""
181176
Attach CDP listener for frame navigation events to track frame IDs.
182177
This mirrors the TypeScript implementation's frame tracking.
@@ -185,55 +180,55 @@ async def _attach_frame_navigated_listener(self, pw_page: Page, stagehand_page:
185180
# Create CDP session for the page
186181
cdp_session = await self._context.new_cdp_session(pw_page)
187182
await cdp_session.send("Page.enable")
188-
183+
189184
# Get the current root frame ID
190185
frame_tree = await cdp_session.send("Page.getFrameTree")
191186
root_frame_id = frame_tree.get("frameTree", {}).get("frame", {}).get("id")
192-
187+
193188
if root_frame_id:
194189
# Initialize the page with its frame ID
195190
stagehand_page.update_root_frame_id(root_frame_id)
196191
self.register_frame_id(root_frame_id, stagehand_page)
197-
192+
198193
# Set up event listener for frame navigation
199194
def on_frame_navigated(params):
200195
"""Handle Page.frameNavigated events"""
201196
frame = params.get("frame", {})
202197
frame_id = frame.get("id")
203198
parent_id = frame.get("parentId")
204-
199+
205200
# Only track root frames (no parent)
206201
if not parent_id and frame_id:
207202
# Skip if it's the same frame ID
208203
if frame_id == stagehand_page.frame_id:
209204
return
210-
205+
211206
# Unregister old frame ID if exists
212207
old_id = stagehand_page.frame_id
213208
if old_id:
214209
self.unregister_frame_id(old_id)
215-
210+
216211
# Register new frame ID
217212
self.register_frame_id(frame_id, stagehand_page)
218213
stagehand_page.update_root_frame_id(frame_id)
219-
214+
220215
self.stagehand.logger.debug(
221216
f"Frame navigated from {old_id} to {frame_id}",
222-
category="context"
217+
category="context",
223218
)
224-
219+
225220
# Register the event listener
226221
cdp_session.on("Page.frameNavigated", on_frame_navigated)
227-
222+
228223
# Clean up frame ID when page closes
229224
def on_page_close():
230225
if stagehand_page.frame_id:
231226
self.unregister_frame_id(stagehand_page.frame_id)
232-
227+
233228
pw_page.once("close", on_page_close)
234-
229+
235230
except Exception as e:
236231
self.stagehand.logger.error(
237232
f"Failed to attach frame navigation listener: {str(e)}",
238-
category="context"
233+
category="context",
239234
)

stagehand/page.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,12 @@ def __init__(self, page: Page, stagehand_client, context=None):
4646
def frame_id(self) -> Optional[str]:
4747
"""Get the current root frame ID."""
4848
return self._frame_id
49-
49+
5050
def update_root_frame_id(self, new_id: str):
5151
"""Update the root frame ID."""
5252
self._frame_id = new_id
53-
self._stagehand.logger.debug(
54-
f"Updated frame ID to {new_id}", category="page"
55-
)
56-
53+
self._stagehand.logger.debug(f"Updated frame ID to {new_id}", category="page")
54+
5755
# TODO try catch here
5856
async def ensure_injection(self):
5957
"""Ensure custom injection scripts are present on the page using domScripts.js."""
@@ -114,7 +112,7 @@ async def goto(
114112
payload = {"url": url}
115113
if options:
116114
payload["options"] = options
117-
115+
118116
# Add frame ID if available
119117
if self._frame_id:
120118
payload["frameId"] = self._frame_id
@@ -192,7 +190,7 @@ async def act(
192190
# Add frame ID if available
193191
if self._frame_id:
194192
payload["frameId"] = self._frame_id
195-
193+
196194
lock = self._stagehand._get_lock_for_session()
197195
async with lock:
198196
result = await self._stagehand._execute("act", payload)
@@ -265,7 +263,7 @@ async def observe(
265263
# Add frame ID if available
266264
if self._frame_id:
267265
payload["frameId"] = self._frame_id
268-
266+
269267
lock = self._stagehand._get_lock_for_session()
270268
async with lock:
271269
result = await self._stagehand._execute("observe", payload)
@@ -393,7 +391,7 @@ async def extract(
393391
# Add frame ID if available
394392
if self._frame_id:
395393
payload["frameId"] = self._frame_id
396-
394+
397395
lock = self._stagehand._get_lock_for_session()
398396
async with lock:
399397
result_dict = await self._stagehand._execute("extract", payload)
@@ -521,7 +519,6 @@ async def _wait_for_settled_dom(self, timeout_ms: int = None):
521519
If None, uses the stagehand client's dom_settle_timeout_ms.
522520
"""
523521

524-
525522
timeout = timeout_ms or getattr(self._stagehand, "dom_settle_timeout_ms", 30000)
526523
client = await self.get_cdp_client()
527524

0 commit comments

Comments
 (0)