left pad here and clean up tests

Author: calvinmetcalf

.travis.yml

@@ -0,0 +1,3 @@
+language: node_js
+node_js:
+  - "0.11"

index.js

@@ -1,14 +1,8 @@
 var bn = require('bn.js');
 module.exports = crt;
-// based on https://github.com/google/end-to-end/blob/bd14d9607e742cd94b1a5af39e0f9e8c454b4a32/src/javascript/crypto/e2e/asymmetric/rsa.js#L196
 function blind(priv, crypto) {
-  var mod = bn.mont(priv.modulus);
   var r = getr(priv, crypto);
-  var p = priv.prime1;
-  var q = priv.prime2;
-  var ONE = new bn(1);
-
-  var blinder = r.toRed(mod)
+  var blinder = r.toRed(bn.mont(priv.modulus))
   .redPow(new bn(priv.publicExponent)).fromRed();
   return {
     blinder: blinder,
@@ -17,6 +11,7 @@ function blind(priv, crypto) {
 }
 function crt(msg, priv, crypto) {
   var blinds = blind(priv, crypto);
+  var len = priv.modulus.byteLength();
   var mod = bn.mont(priv.modulus);
   var blinded = new bn(msg).mul(blinds.blinder).mod(priv.modulus);
   var c1 = blinded.toRed(bn.mont(priv.prime1));
@@ -31,9 +26,15 @@ function crt(msg, priv, crypto) {
   var h = m1.isub(m2).imul(qinv).mod(p);
   h.imul(q);
   m2.iadd(h);
-  return new Buffer(m2.imul(blinds.unblinder).mod(priv.modulus).toArray());
+  var out = new Buffer(m2.imul(blinds.unblinder).mod(priv.modulus).toArray());
+  if (out.length < len) {
+    var prefix = new Buffer(len - out.length);
+    prefix.fill(0);
+    out = Buffer.concat([prefix, out], len);
+  }
+  return out;
 }
-
+crt.getr = getr;
 function getr(priv, crypto) {
   var len = priv.modulus.byteLength();
   var r = new bn(crypto.randomBytes(len));

package.json

@@ -1,10 +1,10 @@
 {
   "name": "browserify-rsa",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "node test.js | tspec"
   },
   "author": "",
   "license": "MIT",
@@ -14,5 +14,10 @@
   "repository": {
     "type": "git",
     "url": "[email protected]:calvinmetcalf/browserify-rsa.git"
+  },
+  "devDependencies": {
+    "tap-spec": "^2.1.2",
+    "tape": "^3.0.3",
+    "parse-asn1": "^1.2.0"
   }
-}
+}

readme.md

@@ -1,4 +1,10 @@
 browserify-rsa
 ====
+[![Build Status](https://travis-ci.org/calvinmetcalf/browserify-rsa.svg)](https://travis-ci.org/calvinmetcalf/browserify-rsa)
 
-RSA private decryption/signing using chinese remainder and blinding.
+RSA private decryption/signing using chinese remainder and blinding.
+
+API
+====
+
+Give it a message as a buffer, a private key (as decoded by https://www.npmjs.com/package/parse-asn1) and a crypto object (aka `require('crypto')`, this is because we use it in browserify crypto and don't want to create a circular dependency)