fix for when getSideEffects loop gets stuck

substack · substack · commit c76033c2b91f · 2022-06-27T22:40:17.000-10:00
diff --git a/index.js b/index.js
@@ -61,8 +61,10 @@ module.exports = function commonShake (b, opts) {
         const file = aliases.get(name) || name
         let pkg
         let dir = file
-        while (!pkg && (dir = path.dirname(dir))) {
+        let prevDir = null
+        while (!pkg && (dir = path.dirname(dir)) && prevDir !== dir) {
           pkg = packages.get(dir)
+          prevDir = dir
         }
         return pkg && pkg.sideEffects === false ? false : true
       }

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,10 @@ module.exports = function commonShake (b, opts) {`
`61`	`61`	`const file = aliases.get(name) \|\| name`
`62`	`62`	`let pkg`
`63`	`63`	`let dir = file`
`64`		`- while (!pkg && (dir = path.dirname(dir))) {`
	`64`	`+ let prevDir = null`
	`65`	`+ while (!pkg && (dir = path.dirname(dir)) && prevDir !== dir) {`
`65`	`66`	`pkg = packages.get(dir)`
	`67`	`+ prevDir = dir`
`66`	`68`	`}`
`67`	`69`	`return pkg && pkg.sideEffects === false ? false : true`
`68`	`70`	`}`