Skip to content

Commit 5620574

Browse files
terinjokesJames Halliday
authored andcommitted
Resolve Stream leaks by Request and Response objects.
1 parent f94793a commit 5620574

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

lib/request.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ var Stream = require('stream');
22
var Response = require('./response');
33
var concatStream = require('concat-stream');
44
var Base64 = require('Base64');
5+
var util = require('util');
56

67
var Request = module.exports = function (xhr, params) {
78
var self = this;
@@ -54,7 +55,7 @@ var Request = module.exports = function (xhr, params) {
5455
};
5556
};
5657

57-
Request.prototype = new Stream;
58+
util.inherits(Request, Stream);
5859

5960
Request.prototype.setHeader = function (key, value) {
6061
if (isArray(value)) {

lib/response.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
var Stream = require('stream');
2+
var util = require('util');
23

34
var Response = module.exports = function (res) {
45
this.offset = 0;
56
this.readable = true;
67
};
78

8-
Response.prototype = new Stream;
9+
util.inherits(Response, Stream);
910

1011
var capable = {
1112
streaming : true,

0 commit comments

Comments
 (0)