Handle errors properly

This groups all streams up with multipipe, except for bl. bl
will catch any errors from the multipipe stream and pass them
onto the `done` callback appropriately.

Fixes #3

Author: hughsk

fixture/index.js renamed to fixtures/basic/index.js

@@ -0,0 +1,11 @@
+const through = require('through2')
+
+module.exports = function () {
+  return through(function () {
+    var stream = this
+
+    setTimeout(function () {
+      stream.emit('error', new Error('Hello world!'))
+    }, 500)
+  })
+}

fixture/package.json renamed to fixtures/basic/package.json

@@ -0,0 +1,3 @@
+const fs = require('fs')
+
+console.log(fs.readFileSync(__dirname + '/package.json', 'utf8'))

fixtures/errors/error.js

@@ -0,0 +1,5 @@
+const through = require('through2')
+
+module.exports = function () {
+  return through()
+}

fixtures/errors/index.js

@@ -0,0 +1,11 @@
+{
+  "name": "fixture",
+  "version": "1.0.0",
+  "browserify": {
+    "transform": [
+      "./error",
+      "./no-error",
+      "brfs"
+    ]
+  }
+}

fixtures/errors/no-error.js

@@ -69,9 +69,9 @@ function loader (source) {
         transforms = []
           .concat(from2([source]))
           .concat(transforms)
-          .concat(bl(done))
 
         multipipe.apply(this, transforms)
+          .pipe(bl(done))
       })
     })
   }

fixtures/errors/package.json

@@ -24,6 +24,7 @@
     "standard": "^5.4.1",
     "tap-spec": "^4.1.1",
     "tape": "^4.4.0",
+    "through2": "^2.0.0",
     "webpack": "^1.12.9"
   },
   "scripts": {

index.js

@@ -7,9 +7,9 @@ const vm = require('vm')
 
 test('ify-loader', function (t) {
   const wpack = which.sync('webpack', { cwd: __dirname })
-  const input = path.join(__dirname, 'fixture', 'index.js')
-  const output = path.join(__dirname, 'fixture', 'bundle.js')
-  const pkg = path.join(__dirname, 'fixture', 'package.json')
+  const input = path.join(__dirname, 'fixtures', 'basic', 'index.js')
+  const output = path.join(__dirname, 'fixtures', 'basic', 'bundle.js')
+  const pkg = path.join(__dirname, 'fixtures', 'basic', 'package.json')
 
   t.plan(1)
 
@@ -38,3 +38,25 @@ test('ify-loader', function (t) {
     })
   })
 })
+
+test('error handling', function (t) {
+  const wpack = which.sync('webpack', { cwd: __dirname })
+  const input = path.join(__dirname, 'fixtures', 'errors', 'index.js')
+  const output = path.join(__dirname, 'fixtures', 'errors', 'bundle.js')
+
+  t.plan(1)
+
+  spawn(wpack, [
+    input,
+    output,
+    '--module-bind', 'js=' + __dirname
+  ], {
+    stdio: ['pipe', 'pipe', 2]
+  }).once('exit', function (code) {
+    try {
+      fs.unlinkSync(output)
+    } catch (e) {}
+
+    t.equal(code, 0, 'exit code zero (they should probably fix that...)')
+  })
+})