Skip to content

Commit 4d6dc59

Browse files
committed
Explicitly set test methods
Don't infer them from value.constructor.name. This doesn't work in IE and it's probably better to be explicit anyway.
1 parent f67d6e3 commit 4d6dc59

File tree

1 file changed

+23
-24
lines changed

1 file changed

+23
-24
lines changed

test/node/types.js

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -41,37 +41,37 @@ var wasmBuffer = Buffer.from('0061736d01000000', 'hex');
4141

4242
for (var _i = 0, _arr = [
4343
// [ external, 'isExternal' ],
44-
[function () { return new Date(); }],
44+
[function () { return new Date(); }, 'isDate'],
4545
[function () { return function () { return arguments; }(); }, 'isArgumentsObject'],
4646
[function () { return new Boolean(); }, 'isBooleanObject'],
4747
[function () { return new Number(); }, 'isNumberObject'],
4848
[function () { return new String(); }, 'isStringObject'],
4949
[function () { return Object(Symbol()); }, 'isSymbolObject'],
5050
[function () { return Object(BigInt(0)); }, 'isBigIntObject'],
5151
[function () { return new Error(); }, 'isNativeError'],
52-
[function () { return new RegExp(); }],
52+
[function () { return new RegExp(); }, 'isRegExp'],
5353
[function () { return eval('(async function() {})'); }, 'isAsyncFunction'],
5454
[function () { return eval('(function*() {})') }, 'isGeneratorFunction'],
5555
[function () { return eval('((function*() {})())') }, 'isGeneratorObject'],
56-
[function () { return Promise.resolve(); }],
57-
[function () { return new Map(); }],
58-
[function () { return new Set(); }],
56+
[function () { return Promise.resolve(); }, 'isPromise'],
57+
[function () { return new Map(); }, 'isMap'],
58+
[function () { return new Set(); }, 'isSet'],
5959
[function () { return new Map()[Symbol.iterator](); }, 'isMapIterator'],
6060
[function () { return new Set()[Symbol.iterator](); }, 'isSetIterator'],
61-
[function () { return new WeakMap(); }],
62-
[function () { return new WeakSet(); }],
63-
[function () { return new ArrayBuffer(); }],
64-
[function () { return new Uint8Array(); }],
65-
[function () { return new Uint8ClampedArray(); }],
66-
[function () { return new Uint16Array(); }],
67-
[function () { return new Uint32Array(); }],
68-
[function () { return new Int8Array(); }],
69-
[function () { return new Int16Array(); }],
70-
[function () { return new Int32Array(); }],
71-
[function () { return new Float32Array(); }],
72-
[function () { return new Float64Array(); }],
73-
[function () { return new BigInt64Array(); }],
74-
[function () { return new BigUint64Array(); }],
61+
[function () { return new WeakMap(); }, 'isWeakMap'],
62+
[function () { return new WeakSet(); }, 'isWeakSet'],
63+
[function () { return new ArrayBuffer(); }, 'isArrayBuffer'],
64+
[function () { return new Uint8Array(); }, 'isUint8Array'],
65+
[function () { return new Uint8ClampedArray(); }, 'isUint8ClampedArray'],
66+
[function () { return new Uint16Array(); }, 'isUint16Array'],
67+
[function () { return new Uint32Array(); }, 'isUint32Array'],
68+
[function () { return new Int8Array(); }, 'isInt8Array'],
69+
[function () { return new Int16Array(); }, 'isInt16Array'],
70+
[function () { return new Int32Array(); }, 'isInt32Array'],
71+
[function () { return new Float32Array(); }, 'isFloat32Array'],
72+
[function () { return new Float64Array(); }, 'isFloat64Array'],
73+
[function () { return new BigInt64Array(); }, 'isBigInt64Array'],
74+
[function () { return new BigUint64Array(); }, 'isBigUint64Array'],
7575
[function () {
7676
if (typeof Symbol === 'undefined' || typeof Symbol.toStringTag === 'undefined') {
7777
throw Error();
@@ -80,15 +80,15 @@ for (var _i = 0, _arr = [
8080
return Object.defineProperty(new Uint8Array(), Symbol.toStringTag, {
8181
value: 'foo'
8282
});
83-
}],
84-
[function () { return new DataView(new ArrayBuffer()); }],
85-
[function () { return new SharedArrayBuffer(); }],
83+
}, 'isUint8Array'],
84+
[function () { return new DataView(new ArrayBuffer()); }, 'isDataView'],
85+
[function () { return new SharedArrayBuffer(); }, 'isSharedArrayBuffer'],
8686
// [ new Proxy({}, {}), 'isProxy' ],
8787
[function () { return new WebAssembly.Module(wasmBuffer); }, 'isWebAssemblyCompiledModule']
8888
]; _i < _arr.length; _i++) {
8989
var _arr$_i = _slicedToArray(_arr[_i], 2),
9090
getValue = _arr$_i[0],
91-
_method = _arr$_i[1];
91+
method = _arr$_i[1];
9292

9393
var _value = void 0;
9494
try {
@@ -97,7 +97,6 @@ for (var _i = 0, _arr = [
9797
console.log('Skipping unsupported type:', getValue);
9898
continue;
9999
}
100-
var method = _method || "is".concat(_value.constructor.name);
101100
console.log('Testing', method);
102101
assert(method in types, "Missing ".concat(method, " for ").concat(inspect(_value)));
103102
assert(types[method](_value), "Want ".concat(inspect(_value), " to match ").concat(method));

0 commit comments

Comments
 (0)