Skip to content

Commit ce3a334

Browse files
committed
Merge pull request #3 from feross/master
Fix util.isBuffer to work in browserify 3.x
2 parents 1a120e0 + 4fb63ce commit ce3a334

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

support/isBufferBrowser.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@ module.exports = function isBuffer(arg) {
22
return arg && typeof arg === 'object'
33
&& typeof arg.copy === 'function'
44
&& typeof arg.fill === 'function'
5-
&& typeof arg.binarySlice === 'function'
6-
;
7-
}
5+
&& typeof arg.readUInt8 === 'function';
6+
}

test/browser/is.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,3 +77,15 @@ test('util._extend', function () {
7777
assert.deepEqual(util._extend({a:1}, {b:2}), {a:1, b:2});
7878
assert.deepEqual(util._extend({a:1, b:2}, {b:3}), {a:1, b:3});
7979
});
80+
81+
test('util.isBuffer', function () {
82+
assert.equal(true, util.isBuffer(new Buffer(4)));
83+
assert.equal(true, util.isBuffer(Buffer(4)));
84+
assert.equal(true, util.isBuffer(new Buffer(4)));
85+
assert.equal(true, util.isBuffer(new Buffer([1, 2, 3, 4])));
86+
assert.equal(false, util.isBuffer({}));
87+
assert.equal(false, util.isBuffer([]));
88+
assert.equal(false, util.isBuffer(new Error()));
89+
assert.equal(false, util.isRegExp(new Date()));
90+
assert.equal(true, util.isBuffer(Object.create(Buffer.prototype)));
91+
});

0 commit comments

Comments
 (0)