You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm facing this issue when running browser tests. The problem is that webpack injects the variables, when compiling, so global and process are different. global is the node and process is the browser process.
@calvinmetcalf Sorry for the completely random ping, but I stumbled upon all this today and you seemed like you were the last active reviewer on this code.
Per pull request #92, process.version was changed to global.process.version in the checks, but the actual access here wasn't changed. This pull requests seems to be the earliest of the multiple requests that would fix this problem.
(Other pull requests are #101, #104, and #116) (Also mentioned in issues #102 and #103)
I have found this one-line change to fully fix my current problems, so it'd be great to have it on npm!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.version is currently undefined which is breaking an app that I'm working on for myself and other windows users on my team.
Switching if from process.version to global.process.version fixes it.