Skip to content

Commit ea9e427

Browse files
author
Shubham Kanodia
committed
Updated support note in README
1 parent 47049a5 commit ea9e427

File tree

8 files changed

+383
-18
lines changed

8 files changed

+383
-18
lines changed

.yarn/install-state.gz

357 Bytes
Binary file not shown.

.yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs

Lines changed: 363 additions & 0 deletions
Large diffs are not rendered by default.

.yarnrc.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
plugins:
2+
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
3+
spec: "@yarnpkg/plugin-interactive-tools"

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ matchesUA(
5656
- Safari Desktop as `Safari`
5757
- IE as `ie` | `ie_mob`
5858
- Edge as `Edge`
59-
- OperaMobile as `OperaMobile`
59+
- Electron as `Electron`
6060

6161
PRs to add more _browserslist supported_ browsers are welcome 👋
6262

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ function resolveUserAgent(uaString) {
124124
}
125125

126126
if (parsedUA.family === 'Electron') {
127-
const electronVersion = [ parsedUA.major, parsedUA.minor ].join('.')
127+
const electronVersion = [parsedUA.major, parsedUA.minor].join('.')
128128
return {
129129
family: 'Chrome',
130130
version: e2c[electronVersion],

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"build": "mkdir -p lib && babel index.js --out-file lib/index.js"
2323
},
2424
"dependencies": {
25-
"browserslist": "^4.12.0",
26-
"electron-to-chromium": "^1.3.815",
25+
"browserslist": "^4.19.1",
26+
"electron-to-chromium": "^1.4.67",
2727
"useragent": "^2.3.0"
2828
},
2929
"devDependencies": {
@@ -32,7 +32,7 @@
3232
"babel-preset-stage-2": "^6.24.1",
3333
"jest": "^23.6.0",
3434
"prettier": "^2.5.1",
35-
"useragent-generator": "^1.1.0"
35+
"useragent-generator": "^1.1.1-amkt-22079-finish.0"
3636
},
3737
"jest": {
3838
"projects": [

tests/index.test.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const CustomUserAgentString = {
1515
'Mozilla/5.0 (iPhone; CPU iPhone OS 8_2 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Mobile/12D508 [FBAN/FBIOS;FBAV/27.0.0.10.12;FBBV/8291884;FBDV/iPhone7,1;FBMD/iPhone;FBSN/iPhone OS;FBSV/8.2;FBSS/3; FBCR/vodafoneIE;FBID/phone;FBLC/en_US;FBOP/5]',
1616
OPERA_MOBILE:
1717
'Opera/9.80 (Android 2.3.3; Linux; Opera Mobi/ADR-1111101157; U; es-ES) Presto/2.9.201 Version/11.50',
18-
ELECTRON:
18+
ELECTRON:
1919
'Mozilla/5.0 (Macintosh; Intel Mac OS X 11_4_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.128 Electron/12.0.13 Safari/537.36',
2020
}
2121

@@ -188,11 +188,10 @@ it('resolves samsung browser properly', () => {
188188

189189
it('resolves electron properly', () => {
190190
// Electron 12 -> Chrome 89
191-
expect(resolveUserAgent(CustomUserAgentString.ELECTRON))
192-
.toEqual({
193-
family: 'Chrome',
194-
version: '89'
195-
})
191+
expect(resolveUserAgent(CustomUserAgentString.ELECTRON)).toEqual({
192+
family: 'Chrome',
193+
version: '89',
194+
})
196195
})
197196

198197
it('detects if browserslist matches UA', () => {

yarn.lock

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1332,11 +1332,11 @@ __metadata:
13321332
babel-preset-es2015: ^6.24.1
13331333
babel-preset-stage-2: ^6.24.1
13341334
browserslist: ^4.19.1
1335+
electron-to-chromium: ^1.4.67
13351336
jest: ^23.6.0
13361337
prettier: ^2.5.1
1337-
semver: ^7.3.5
13381338
useragent: ^2.3.0
1339-
useragent-generator: ^1.1.0
1339+
useragent-generator: ^1.1.1-amkt-22079-finish.0
13401340
languageName: unknown
13411341
linkType: soft
13421342

@@ -1881,7 +1881,7 @@ __metadata:
18811881
languageName: node
18821882
linkType: hard
18831883

1884-
"electron-to-chromium@npm:^1.4.17":
1884+
"electron-to-chromium@npm:^1.4.17, electron-to-chromium@npm:^1.4.67":
18851885
version: 1.4.67
18861886
resolution: "electron-to-chromium@npm:1.4.67"
18871887
checksum: 687fa3b403504d5ecabac2a0ab59754d59187b8cfca2d5cf34c83eef0791a5d60a4378df84b811d81804c22e8c9dad02c89d9bc03b28fb547cb2bb52e1f7eeb9
@@ -6039,14 +6039,14 @@ __metadata:
60396039
languageName: node
60406040
linkType: hard
60416041

6042-
"useragent-generator@npm:^1.1.0":
6043-
version: 1.1.0
6044-
resolution: "useragent-generator@npm:1.1.0"
6042+
"useragent-generator@npm:^1.1.1-amkt-22079-finish.0":
6043+
version: 1.1.1-amkt-22079-finish.1
6044+
resolution: "useragent-generator@npm:1.1.1-amkt-22079-finish.1"
60456045
dependencies:
60466046
normalize-version: ^1.0.5
60476047
semver: ^5.4.1
60486048
semver-closest: ^0.1.0
6049-
checksum: 077a21580125627927032f8ee0ff7f8b640ed4d275b58f6bfa74cc277320226635ddd1a2ccc782c5dba405df0229551498e710068d8b40f99740e72cc36f0e11
6049+
checksum: 81ac764f08da0c6f6507e203714e03238afad4c63d0d27cdca85a14d1ff7ebaa6be5eb6ec6683e6c53f5e0c06aba0b70783ec580cbfd0fee8c2a3da27525908c
60506050
languageName: node
60516051
linkType: hard
60526052

0 commit comments

Comments
 (0)