Skip to content

Breaks when browserslist includes unreleased Safari versions #38

@sgomes

Description

@sgomes

On a browserslist that includes unreleased Safari versions, the library seems to break when accessed with any Safari version (not just Safari TP), presumably because it's being compared against the browserslist versions.

TypeError: Invalid Version: TP.0.0
    at new SemVer (/devpath/wp-calypso/node_modules/semver/semver.js:312:11)
    at compare (/devpath/wp-calypso/node_modules/semver/semver.js:585:39)
    at Function.gte (/devpath/wp-calypso/node_modules/semver/semver.js:634:10)
    at compareBrowserSemvers (/devpath/wp-calypso/node_modules/browserslist-useragent/lib/index.js:182:19)
    at /devpath/wp-calypso/node_modules/browserslist-useragent/lib/index.js:208:93
    at Array.some (<anonymous>)
    at matchesUA (/devpath/wp-calypso/node_modules/browserslist-useragent/lib/index.js:207:25)

The issue appears to be the non-numeric nature of Safari TP's version "numbering", possibly when combined with the following browserslist-useragent flags: ignorePatch: true, ignoreMinor: true, allowHigherVersions: true.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions