Merge pull request abronte#36 from kysnm/add-optional-parameters-for-tabledata-list

Support optional parameters for Tabledata.list

Author: abronte

lib/big_query/client/tables.rb

@@ -35,11 +35,14 @@ def tables_formatted(dataset = @dataset)
       #
       # @param tableId [String] id of the table to look for
       # @param dataset [String] dataset to look for
+      # @param options [Hash] hash of optional query parameters (maxResults, startIndex)
       # @return [Hash] json api response
-      def table_data(tableId, dataset = @dataset)
+      def table_data(tableId, dataset = @dataset, options = {})
+        parameters = { 'datasetId' => dataset, 'tableId' => tableId }
+        parameters['maxResults'] = options[:maxResults] if options[:maxResults]
+        parameters['startIndex'] = options[:startIndex] if options[:startIndex]
         response = api(api_method: @bq.tabledata.list,
-                       parameters: { 'datasetId' => dataset,
-                                     'tableId' => tableId })
+                       parameters: parameters)
         response['rows'] || []
       end
 

test/bigquery.rb

@@ -48,6 +48,19 @@ def test_for_table_data
     assert_kind_of Array, result
   end
 
+  def test_for_table_data_maxResults
+    result = @bq.table_data('test', @bq.dataset, maxResults: 100)
+
+    assert_kind_of Array, result
+  end
+
+  def test_for_table_data_startIndex
+    # startIndex is Zero-based
+    result = @bq.table_data('test', @bq.dataset, maxResults: 100, startIndex: 100)
+
+    assert_kind_of Array, result
+  end
+
   def test_for_create_table
     if @bq.tables_formatted.include? 'test123'
       @bq.delete_table('test123')