From f3813dc92962a2424389acbac8b5fbf30952c2f3 Mon Sep 17 00:00:00 2001 From: Arjun Chikara Date: Mon, 21 Apr 2025 11:30:00 +0530 Subject: [PATCH 1/2] fixed needs review messages --- lib/checks/label/label-content-name-mismatch.json | 3 ++- lib/rules/label-content-name-mismatch.json | 1 + lib/rules/p-as-heading.json | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/checks/label/label-content-name-mismatch.json b/lib/checks/label/label-content-name-mismatch.json index 872ca0a6c..78b12f02e 100644 --- a/lib/checks/label/label-content-name-mismatch.json +++ b/lib/checks/label/label-content-name-mismatch.json @@ -9,7 +9,8 @@ "impact": "serious", "messages": { "pass": "Element contains visible text as part of it's accessible name", - "fail": "Text inside the element is not included in the accessible name" + "fail": "Text inside the element is not included in the accessible name", + "incomplete": "Ensure that the visible label of the element and the accessible name (provided by `aria-label`, etc.) match exactly. Ensure that the visible label of the element is part of the accessible name of the element. It is advisable that the visible label comes in the beginning of the accessible name" } } } diff --git a/lib/rules/label-content-name-mismatch.json b/lib/rules/label-content-name-mismatch.json index d9efcb7a7..67cd43acf 100644 --- a/lib/rules/label-content-name-mismatch.json +++ b/lib/rules/label-content-name-mismatch.json @@ -8,6 +8,7 @@ "wcag253", "EN-301-549", "EN-9.2.5.3", + "a11y-engine", "a11y-engine-experimental" ], "actIds": ["2ee8b8"], diff --git a/lib/rules/p-as-heading.json b/lib/rules/p-as-heading.json index 493e5eb9c..39a3adde3 100644 --- a/lib/rules/p-as-heading.json +++ b/lib/rules/p-as-heading.json @@ -9,6 +9,7 @@ "wcag131", "EN-301-549", "EN-9.1.3.1", + "a11y-engine", "a11y-engine-experimental" ], "metadata": { From 9b15429c5f1f74c36ec8cbf4d3d864c138f70e79 Mon Sep 17 00:00:00 2001 From: Arjun Chikara Date: Mon, 21 Apr 2025 11:32:16 +0530 Subject: [PATCH 2/2] fixed messages --- lib/checks/label/label-content-name-mismatch.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/checks/label/label-content-name-mismatch.json b/lib/checks/label/label-content-name-mismatch.json index 78b12f02e..5666d43b3 100644 --- a/lib/checks/label/label-content-name-mismatch.json +++ b/lib/checks/label/label-content-name-mismatch.json @@ -9,8 +9,8 @@ "impact": "serious", "messages": { "pass": "Element contains visible text as part of it's accessible name", - "fail": "Text inside the element is not included in the accessible name", - "incomplete": "Ensure that the visible label of the element and the accessible name (provided by `aria-label`, etc.) match exactly. Ensure that the visible label of the element is part of the accessible name of the element. It is advisable that the visible label comes in the beginning of the accessible name" + "fail": "Ensure that the visible label of the element and the accessible name (provided by `aria-label`, etc.) match exactly. Ensure that the visible label of the element is part of the accessible name of the element. It is advisable that the visible label comes in the beginning of the accessible name", + "incomplete": "Check if the visible text is part of the accessible name (provided by `aria-label`, etc.) for the element. Check the accessibility tree to get the accessible name of the element." } } }