Skip to content

Commit 58bca26

Browse files
committed
Make config management developer friendly
1 parent 20c9928 commit 58bca26

File tree

4 files changed

+17
-11
lines changed

4 files changed

+17
-11
lines changed

.env.production

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
APP_ENV=production
2+
UPLOAD_URL=https://api-cloud.browserstack.com/automate-frameworks/cypress/upload
3+
RAILS_HOST=https://api.browserstack.com
4+
DASHBOARD_URL=https://automate.browserstack.com/dashboard/v2/builds/
5+
USAGE_REPORTING_URL=https://eds.browserstack.com:443/send_event_cy_internal

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@ specs
55
tests.zip
66
package-lock.json
77
.nyc_output/
8+
.env.*
9+
!.env.production

bin/helpers/config.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
var config = {};
2-
config.env = "prod";
3-
var hosts = {
4-
prod: {
5-
uploadUrl: `https://api-cloud.browserstack.com/automate-frameworks/cypress/upload`,
6-
rails_host: `https://api.browserstack.com`
7-
}
8-
};
9-
config.uploadUrl = hosts[config.env].uploadUrl;
10-
config.rails_host = hosts[config.env].rails_host;
2+
config.env = process.env.NODE_ENV || "production";
3+
4+
// load config based on env
5+
require('custom-env').env(config.env)
6+
7+
config.uploadUrl = process.env.UPLOAD_URL;
8+
config.rails_host = process.env.RAILS_HOST;
119
config.cypress_v1 = `${config.rails_host}/automate/cypress/v1`;
1210
config.buildUrl = `${config.cypress_v1}/builds/`;
1311
config.buildStopUrl = `${config.cypress_v1}/builds/stop/`;
14-
config.dashboardUrl = `https://automate.browserstack.com/dashboard/v2/builds/`;
15-
config.usageReportingUrl = `https://eds.browserstack.com:443/send_event_cy_internal`;
12+
config.dashboardUrl = process.env.DASHBOARD_URL;
13+
config.usageReportingUrl = process.env.USAGE_REPORTING_URL;
1614
config.fileName = "tests.zip";
1715

1816
module.exports = config;

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"devDependencies": {
3232
"chai": "^4.2.0",
3333
"chai-as-promised": "^7.1.1",
34+
"custom-env": "^2.0.1",
3435
"mocha": "^7.1.2",
3536
"nyc": "^15.0.1",
3637
"proxyquire": "^2.1.3",

0 commit comments

Comments
 (0)