moved exit code to constants

Author: roshan04

bin/commands/runs.js

@@ -180,7 +180,7 @@ module.exports = function run(args, rawArgs) {
                     await new Promise(resolve => setTimeout(resolve, 5000));
 
                     // download build artifacts
-                    if (exitCode != config.buildFailedExitCode) {
+                    if (exitCode != Constants.BUILD_FAILED_EXIT_CODE) {
                       if (utils.nonEmptyArray(bsConfig.run_settings.downloads)) {
                         await downloadBuildArtifacts(bsConfig, data.build_id, args, rawArgs);
                       }
@@ -194,7 +194,7 @@ module.exports = function run(args, rawArgs) {
                       let stacktraceUrl = getStackTraceUrl();
                       await downloadBuildStacktrace(stacktraceUrl);
                       logger.info(Constants.userMessages.BUILD_FAILED_ERROR)
-                      process.exitCode = Constants.ERROR_EXIT_CODE;
+                      process.exitCode = Constants.BUILD_FAILED_EXIT_CODE;
                     }
                   });
                 } else if (utils.nonEmptyArray(bsConfig.run_settings.downloads)) {

bin/helpers/constants.js

@@ -218,6 +218,8 @@ const AUTH_REGEX = /"auth" *: *{[\s\S]*?}/g
 
 const ERROR_EXIT_CODE = 1;
 
+const BUILD_FAILED_EXIT_CODE = 3;
+
 const REDACTED = "[REDACTED]";
 
 const REDACTED_AUTH =`auth: { "username": ${REDACTED}, "access_key": ${REDACTED} }`;
@@ -241,5 +243,6 @@ module.exports = Object.freeze({
   LATEST_VERSION_SYNTAX_REGEX,
   ERROR_EXIT_CODE,
   AUTH_REGEX,
-  REDACTED_AUTH
+  REDACTED_AUTH,
+  BUILD_FAILED_EXIT_CODE
 });

bin/helpers/sync/syncSpecsLogs.js

@@ -169,7 +169,7 @@ let showSpecsStatus = (data) => {
     if (specDetails == "created") {
       return;
     } else if (specDetails["stacktrace_url"]) {
-      specSummary.exitCode = config.buildFailedExitCode;
+      specSummary.exitCode = Constants.BUILD_FAILED_EXIT_CODE;
       specSummary.buildError = specDetails["stacktrace_url"]
       winstonLogger.error(chalk.red(specDetails["message"]));
     } else {