reverting update config command, moving npm_dependencies to run settings

Author: suryart

bin/commands/runs.js

@@ -31,7 +31,7 @@ function runCypress(args) {
   capabilityHelper.validate(bsConfig).then(function (validated) {
     logger.log(validated);
     // Archive the spec files
-    archiver.archive(bsConfig, config.fileName).then(function (data) {
+    archiver.archive(bsConfig.run_settings, config.fileName).then(function (data) {
       // Uploaded zip file
       zipUploader.zipUpload(bsConfig, config.fileName).then(function (zip) {
         // Create build

bin/commands/updateConfig.js

@@ -3,11 +3,11 @@ const fs = require('fs'),
   archiver = require('archiver'),
   logger = require("./logger");
 
-const archiveSpecs = (bsConfig, filePath) => {
+const archiveSpecs = (runSettings, filePath) => {
   return new Promise(function (resolve, reject) {
     var output = fs.createWriteStream(filePath);
 
-    var cypressFolderPath = bsConfig.run_settings.cypress_proj_dir
+    var cypressFolderPath = runSettings.cypress_proj_dir;
 
     var archive = archiver('zip', {
       zlib: { level: 9 } // Sets the compression level.
@@ -35,7 +35,7 @@ const archiveSpecs = (bsConfig, filePath) => {
 
     archive.pipe(output);
 
-    var packageJSON = JSON.stringify({devDependencies: bsConfig.npm_dependencies}, null, 4);
+    var packageJSON = JSON.stringify({devDependencies: runSettings.npm_dependencies}, null, 4);
 
     let allowedFileTypes = [ 'js', 'json', 'txt', 'ts' ]
     allowedFileTypes.forEach(fileType => {

bin/helpers/archiver.js

@@ -37,26 +37,6 @@ var argv = yargs
       return require('./commands/init')(argv);
     }
   })
-  .command('update-config', Constants.cliMessages.UPDATE_CONFIG.INFO, function(yargs) {
-    argv = yargs
-      .usage('usage: $0 update-config')
-      .options('cf', {
-        alias: 'config-file',
-        describe: Constants.cliMessages.UPDATE_CONFIG.CONFIG_DEMAND_DESC,
-        default: '/browserstack.json',
-        type: 'string',
-        nargs: 1,
-        demand: true,
-        demand: Constants.cliMessages.UPDATE_CONFIG.CONFIG_DEMAND
-      })
-      .help('help')
-      .wrap(null)
-      .argv
-
-    if (checkCommands(yargs, argv, 1)) {
-      return require('./commands/updateConfig')(argv);
-    }
-  })
   .command('build-info', Constants.cliMessages.BUILD.INFO, function(yargs) {
     argv = yargs
       .usage('usage: $0 <buildId>')

bin/runner.js

@@ -14,14 +14,14 @@ module.exports = function () {
     "run_settings": {
       "cypress_proj_dir" : "/dir/to/cypress.json",
       "project": "project-name",
-      "customBuildName": "build-name"
+      "customBuildName": "build-name",
+      "npm_dependencies": {
+      }
     },
     "connection_settings": {
       "local": false,
       "localIdentifier": null
     },
-    "npm_dependencies": {
-    }
   }
   var EOL = require('os').EOL
   var file = [