Removing dependencies and correcting code and unit tests

Author: suryart

bin/commands/generateReport.js

@@ -1,10 +1,9 @@
 'use strict';
 
-const config = require("../helpers/config"),
-  logger = require("../helpers/logger").winstonLogger,
-  Constants = require("../helpers/constants"),
-  utils = require("../helpers/utils"),
-  reporterHTML = require('../helpers/reporterHTML');
+const logger = require("../helpers/logger").winstonLogger,
+      Constants = require("../helpers/constants"),
+      utils = require("../helpers/utils"),
+      reporterHTML = require('../helpers/reporterHTML');
 
 
 module.exports = function generateReport(args) {
@@ -26,12 +25,10 @@ module.exports = function generateReport(args) {
     // set cypress config filename
     utils.setCypressConfigFilename(bsConfig, args);
 
-    let buildId = args._[1];
-
     let messageType = Constants.messageTypes.INFO;
     let errorCode = null;
 
-    reportGenerator(bsConfig, buildId);
+    reportGenerator(bsConfig, args);
     utils.sendUsageReport(bsConfig, args, 'generate-report called', messageType, errorCode);
   }).catch(function (err) {
     logger.error(err);

test/unit/bin/commands/generateReport.js

@@ -4,8 +4,7 @@ const chai = require("chai"),
 
 const Constants = require("../../../../bin/helpers/constants"),
       logger = require("../../../../bin/helpers/logger").winstonLogger,
-      testObjects = require("../../support/fixtures/testObjects"),
-      reporterHTML = require('../helpers/reporterHTML');
+      testObjects = require("../../support/fixtures/testObjects");
 
 const proxyquire = require("proxyquire").noCallThru();
 
@@ -67,7 +66,7 @@ describe("generateReport", () => {
 
       generateReport(args)
       .then(function (_bsConfig) {
-        sinon.assert.calledWith(reportGeneratorSpy, bsConfig, args._[1]);
+        sinon.assert.calledWith(reportGeneratorSpy, bsConfig, args);
         sinon.assert.calledOnce(getConfigPathStub);
         sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, 'generate-report called', Constants.messageTypes.INFO, null);
       })