Handle path not found while doing init

Author: SagarGaniga

bin/commands/init.js

@@ -22,13 +22,21 @@ module.exports = function init(args) {
     utils.sendUsageReport(null, args, message, Constants.messageTypes.SUCCESS, null);
   }
 
-  return fileHelpers.fileExists(config.path, function(exists){
-    if (exists) {
-      let message = Constants.userMessages.CONFIG_FILE_EXISTS;
-      logger.error(message);
-      utils.sendUsageReport(null, args, message, Constants.messageTypes.ERROR, 'bstack_json_already_exists');
+  return fileHelpers.dirExists(config.path, function(dirExists){
+    if (dirExists) {
+      fileHelpers.fileExists(config.path, function(exists){
+        if (exists) {
+          let message = Constants.userMessages.CONFIG_FILE_EXISTS;
+          logger.error(message);
+          utils.sendUsageReport(null, args, message, Constants.messageTypes.ERROR, 'bstack_json_already_exists');
+        } else {
+          fileHelpers.write(config, null, allDone);
+        }
+      });
     } else {
-      fileHelpers.write(config, null, allDone);
+      let message = Constants.userMessages.DIR_NOT_FOUND;
+      logger.error(message);
+      utils.sendUsageReport(null, args, message, Constants.messageTypes.ERROR, 'path_to_init_not_found');
     }
   });
 }

bin/helpers/constants.js

@@ -7,6 +7,7 @@ const userMessages = {
     ZIP_UPLOAD_FAILED: "Zip Upload failed.",
     CONFIG_FILE_CREATED: "BrowserStack Config File created, you can now run browserstack-cypress --config-file run",
     CONFIG_FILE_EXISTS: "File already exists, delete the browserstack.json file manually. skipping...",
+    DIR_NOT_FOUND: "Given path does not exist. Failed to create browserstack.json.",
     ZIP_DELETE_FAILED: "Could not delete local file.",
     ZIP_DELETED: "Zip file deleted successfully.",
     API_DEPRECATED: "This version of API is deprecated, please use latest version of API.",

bin/helpers/fileHelpers.js

@@ -35,3 +35,11 @@ exports.deleteZip = () => {
     }
   });
 }
+
+exports.dirExists = function (filePath, cb) {
+  let exists = false;
+  if (fs.existsSync(path.dirname(filePath), cb)) {
+    exists = true;
+  }
+  cb && cb(exists);
+}

test/unit/bin/commands/init.js

@@ -15,20 +15,41 @@ describe("init", () => {
   let args = testObjects.initSampleArgs;
   var sandbox;
 
-  before(() => {
+  beforeEach(() => {
     sandbox = sinon.createSandbox();
     sendUsageReportStub = sandbox.stub().callsFake(function () {
       return "end";
     });
   });
 
-  after(() => {
+  afterEach(() => {
     sandbox.restore();
     sinon.restore();
   });
 
   describe("init", () => {
+    it("fail if given path is not present", () => {
+      dirExistsStub = sandbox.stub().yields(false);
+      writeStub = sandbox.stub();
+
+      const init = proxyquire("../../../../bin/commands/init", {
+        "../helpers/utils": {
+          sendUsageReport: sendUsageReportStub,
+        },
+        "../helpers/fileHelpers": {
+          dirExists: dirExistsStub,
+          write: writeStub,
+        },
+      });
+
+      init(args);
+      sinon.assert.calledOnce(dirExistsStub);
+      sinon.assert.notCalled(writeStub);
+      sinon.assert.calledOnceWithExactly(sendUsageReportStub, null, args, Constants.userMessages.DIR_NOT_FOUND, Constants.messageTypes.ERROR, 'path_to_init_not_found');
+    });
+
     it("fail if browserstack.json is already present", () => {
+      dirExistsStub = sandbox.stub().yields(true);
       fileExistsStub = sandbox.stub().yields(true);
       writeStub = sandbox.stub();
 
@@ -37,18 +58,21 @@ describe("init", () => {
           sendUsageReport: sendUsageReportStub,
         },
         "../helpers/fileHelpers": {
+          dirExists: dirExistsStub,
           fileExists: fileExistsStub,
           write: writeStub,
         },
       });
 
       init(args);
+      sinon.assert.calledOnce(dirExistsStub);
       sinon.assert.calledOnce(fileExistsStub);
       sinon.assert.notCalled(writeStub);
       sinon.assert.calledOnceWithExactly(sendUsageReportStub, null, args, Constants.userMessages.CONFIG_FILE_EXISTS, Constants.messageTypes.ERROR, 'bstack_json_already_exists');
     });
 
     it("create browserstack.json if not already present", () => {
+      dirExistsStub = sandbox.stub().yields(true);
       fileExistsStub = sandbox.stub().yields(false);
       writeStub = sandbox.stub();
 
@@ -57,12 +81,14 @@ describe("init", () => {
           sendUsageReport: sendUsageReportStub,
         },
         "../helpers/fileHelpers": {
+          dirExists: dirExistsStub,
           fileExists: fileExistsStub,
           write: writeStub,
         },
       });
 
       init(args);
+      sinon.assert.calledOnce(dirExistsStub);
       sinon.assert.calledOnce(fileExistsStub);
       sinon.assert.calledOnce(writeStub);
     });