Skip to content

Commit b9d6d96

Browse files
committed
remove unused modules and add a new constant
1 parent 37080f8 commit b9d6d96

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

bin/helpers/constants.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const userMessages = {
2626
MD5_CHECK_FAILED: "There was some issue while checking if zip is already uploaded.",
2727
ZIP_DELETE_FAILED: "Could not delete tests.zip successfully.",
2828
ZIP_DELETED: "Deleted tests.zip successfully.",
29+
NPM_INSTALL_AND_UPLOAD: "Installing required dependencies and building the package to upload to BrowserStack",
2930
NPM_DELETE_FAILED: "Could not delete the dependency packages.",
3031
NPM_DELETED: "Deleted dependency packages successfully.",
3132
API_DEPRECATED: "This version of API is deprecated, please use latest version of API.",

bin/helpers/packageInstaller.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
'use strict';
2-
const npm = require('npm'),
3-
archiver = require("archiver"),
2+
const archiver = require("archiver"),
43
path = require('path'),
5-
os = require('os'),
64
fs = require('fs-extra'),
75
fileHelpers = require('./fileHelpers'),
86
logger = require("./logger").winstonLogger,
@@ -109,7 +107,7 @@ const packageWrapper = (bsConfig, packageDir, packageFile, md5data, instrumentBl
109107
if (md5data.packageUrlPresent || !utils.isTrueString(bsConfig.run_settings.cache_dependencies)) {
110108
return resolve(obj);
111109
}
112-
logger.info(`Installing required dependencies and building the package to upload to BrowserStack`);
110+
logger.info(Constants.userMessages.NPM_INSTALL_AND_UPLOAD);
113111
instrumentBlocks.markBlockStart("packageInstaller.folderSetup");
114112
return setupPackageFolder(bsConfig.run_settings, packageDir).then((_result) => {
115113
process.env.CYPRESS_INSTALL_BINARY = 0

0 commit comments

Comments
 (0)