Skip to content

Commit cf22819

Browse files
committed
version change message as per spec
1 parent 457830f commit cf22819

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

bin/commands/runs.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ module.exports = function run(args) {
6868
}
6969

7070
if (bsConfig.cypress_version && bsConfig.cypress_version !== data.cypress_version) {
71-
logger.warn(Constants.userMessages.CYPRESS_VERSION_CHANGED);
71+
message = utils.versionChangedMessage(bsConfig.cypress_version, data.cypress_version)
72+
logger.warn(message);
7273
}
7374

7475
if (!args.disableNpmWarning && bsConfig.run_settings.npm_dependencies && Object.keys(bsConfig.run_settings.npm_dependencies).length <= 0) {

bin/helpers/constants.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const userMessages = {
3636
FATAL_NETWORK_ERROR: `fatal: unable to access '${config.buildUrl}': Could not resolve host: ${config.rails_host}`,
3737
RETRY_LIMIT_EXCEEDED: `Max retries exceeded trying to connect to the host (retries: ${config.retries})`,
3838
CHECK_DASHBOARD_AT: "Please check the build status at: ",
39-
CYPRESS_VERSION_CHANGED: "You passed an invalid version and we changed it to a proper one."
39+
CYPRESS_VERSION_CHANGED: "You specified <preferredVersion> as the preferred Cypress version. Note that we run the tests on <actualVersion>"
4040
};
4141

4242
const validationMessages = {

bin/helpers/utils.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,3 +374,9 @@ exports.getNetworkErrorMessage = (dashboard_url) => {
374374
+ Constants.userMessages.CHECK_DASHBOARD_AT + dashboard_url
375375
return chalk.red(message)
376376
}
377+
378+
exports.versionChangedMessage = (preferredVersion, actualVersion) => {
379+
let message = Constants.userMessages.CYPRESS_VERSION_CHANGED.replace("<preferredVersion>", preferredVersion);
380+
message = version_message.replace("<actualVersion>", actualVersion);
381+
return message
382+
}

0 commit comments

Comments
 (0)