Skip to content

Commit e278e43

Browse files
committed
🎨 should show error message when build stopped
1 parent f5a3b0c commit e278e43

File tree

1 file changed

+35
-41
lines changed

1 file changed

+35
-41
lines changed

bin/helpers/utils.js

Lines changed: 35 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1305,55 +1305,49 @@ exports.stopBrowserStackBuild = async (bsConfig, args, buildId, rawArgs, buildRe
13051305
auth: options.auth,
13061306
headers: options.headers
13071307
});
1308-
try {
1309-
build = response.data;
1310-
if (response.status == 299) {
1311-
messageType = Constants.messageTypes.INFO;
1312-
errorCode = 'api_deprecated';
1313-
1314-
if (build) {
1315-
message = build.message;
1316-
logger.info(message);
1317-
} else {
1318-
message = Constants.userMessages.API_DEPRECATED;
1319-
logger.info(message);
1320-
}
1321-
} else if (response.status !== 200) {
1322-
messageType = Constants.messageTypes.ERROR;
1323-
errorCode = 'api_failed_build_stop';
1324-
1325-
if (build) {
1326-
message = `${
1327-
Constants.userMessages.BUILD_STOP_FAILED
1328-
} with error: \n${JSON.stringify(build, null, 2)}`;
1329-
logger.error(message);
1330-
if (build.message === 'Unauthorized') errorCode = 'api_auth_failed';
1331-
} else {
1332-
message = Constants.userMessages.BUILD_STOP_FAILED;
1333-
logger.error(message);
1334-
}
1308+
1309+
build = response.data;
1310+
if (response.status == 299) {
1311+
messageType = Constants.messageTypes.INFO;
1312+
errorCode = 'api_deprecated';
1313+
1314+
if (build) {
1315+
message = build.message;
1316+
logger.info(message);
13351317
} else {
1336-
messageType = Constants.messageTypes.SUCCESS;
1337-
message = `${JSON.stringify(build, null, 2)}`;
1318+
message = Constants.userMessages.API_DEPRECATED;
13381319
logger.info(message);
13391320
}
1340-
} catch(err) {
1341-
if(err.response) {
1321+
} else if (response.status !== 200) {
1322+
messageType = Constants.messageTypes.ERROR;
1323+
errorCode = 'api_failed_build_stop';
1324+
1325+
if (build) {
13421326
message = `${
13431327
Constants.userMessages.BUILD_STOP_FAILED
1344-
} with error: ${error.response.data.message}`;
1345-
messageType = Constants.messageTypes.ERROR;
1346-
errorCode = 'api_failed_build_stop';
1328+
} with error: \n${JSON.stringify(build, null, 2)}`;
1329+
logger.error(message);
1330+
if (build.message === 'Unauthorized') errorCode = 'api_auth_failed';
1331+
} else {
1332+
message = Constants.userMessages.BUILD_STOP_FAILED;
13471333
logger.error(message);
13481334
}
1349-
} finally {
1350-
that.sendUsageReport(bsConfig, args, message, messageType, errorCode, buildReportData, rawArgs);
1335+
} else {
1336+
messageType = Constants.messageTypes.SUCCESS;
1337+
message = `${JSON.stringify(build, null, 2)}`;
1338+
logger.info(message);
13511339
}
1352-
} catch (error) {
1353-
message = Constants.userMessages.BUILD_STOP_FAILED;
1354-
messageType = Constants.messageTypes.ERROR;
1355-
errorCode = 'api_failed_build_stop';
1356-
logger.info(message);
1340+
} catch(err) {
1341+
if(err.response) {
1342+
message = `${
1343+
Constants.userMessages.BUILD_STOP_FAILED
1344+
} with error: ${err.response.data.message}`;
1345+
messageType = Constants.messageTypes.ERROR;
1346+
errorCode = 'api_failed_build_stop';
1347+
logger.error(message);
1348+
}
1349+
} finally {
1350+
that.sendUsageReport(bsConfig, args, message, messageType, errorCode, buildReportData, rawArgs);
13571351
}
13581352
}
13591353

0 commit comments

Comments
 (0)