updated bugs and binary path issue

Author: tr4n2uil

README.md

@@ -34,7 +34,7 @@ gem install browserstack-local
 * `localIdentifier`: If doing simultaneous multiple local testing connections, set this uniquely for different processes
 * `hosts`: List of hosts and ports where Local must be enabled for eg. localhost,3000,1,localhost,3001,0
 * `logfile`: Path to file where Local logs be saved to
-* `binaryPath`: Optional path to Local binary
+* `binarypath`: Optional path to Local binary
 
 
 ## Build

lib/browserstack/local.rb

@@ -6,13 +6,8 @@ module BrowserStack
 class Local
   attr_reader :pid
 
-  def initialize(key = nil, binary_path = nil)
+  def initialize(key = nil)
     @key = key
-    @binary_path = if binary_path.nil?
-        BrowserStack::LocalBinary.new.binary_path
-      else
-        binary_path
-      end
     @logfile = File.join(Dir.pwd, "local.log")
   end
 
@@ -46,6 +41,8 @@ def add_args(key, value=nil)
       @hosts = value
     elsif key == "logfile"
       @logfile = value
+    elsif key == "binarypath"
+      @binary_path = value
     end
   end
 
@@ -54,6 +51,12 @@ def start(options = {})
       self.add_args(key, value)
     end
 
+    @binary_path = if @binary_path.nil?
+        BrowserStack::LocalBinary.new.binary_path
+      else
+        @binary_path
+      end
+    
     system("echo '' > '#{@logfile}'")
     @process = IO.popen(command, "w+")
     @stdout = File.open(@logfile, "r")
@@ -85,7 +88,7 @@ def start(options = {})
   end
 
   def isRunning
-    return true if (!@pid.nil? && Process::kill(0, @pid)) rescue false
+    return true if (!@pid.nil? && Process.kill(0, @pid)) rescue false
   end
 
   def stop

lib/browserstack/localbinary.rb

@@ -77,7 +77,7 @@ def get_available_dirs
 
   def make_path(path)
     begin
-      FileUtils.mkdir_p path if !Dir.exists?(path)
+      FileUtils.mkdir_p path if !File.directory?(path)
       return true
     rescue Exception => e
       puts "Exception #{e.message} #{e.backtrace}"

test/browserstack-local-test.rb

@@ -4,24 +4,24 @@
 
 class BrowserStackLocalTest < Minitest::Test
   def setup
-    @bs_local = BrowserStack::Local.new(ENV["BROWSERSTACK_ACCESS_KEY"])
+    @bs_local = BrowserStack::Local.new
   end
 
   def test_check_pid
-    @bs_local.start
+    @bs_local.start({'key' => ENV["BROWSERSTACK_ACCESS_KEY"]})
     refute_nil @bs_local.pid, 0
   end
 
   def test_is_running
-    @bs_local.start
+    @bs_local.start({'key' => ENV["BROWSERSTACK_ACCESS_KEY"]})
     assert_equal true, @bs_local.isRunning
   end
 
   def test_multiple_binary
-    @bs_local.start
-    bs_local_2 = BrowserStack::Local.new(ENV["BROWSERSTACK_ACCESS_KEY"])
+    @bs_local.start({'key' => ENV["BROWSERSTACK_ACCESS_KEY"]})
+    bs_local_2 = BrowserStack::Local.new
     assert_raises BrowserStack::LocalException do
-      bs_local_2.start
+      bs_local_2.start({'key' => ENV["BROWSERSTACK_ACCESS_KEY"]})
     end
   end