Skip to content

Commit 92852fb

Browse files
committed
try popen args
1 parent 6ae7740 commit 92852fb

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

lib/browserstack/local.rb

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ def start(options = {})
5858
end
5959

6060
system("echo '' > '#{@logfile}'")
61-
@pid = Process.spawn(command)
62-
Process.detach @pid
63-
#@process = IO.popen(command)
61+
#@pid = spawn()
62+
#Process.detach @pid
63+
@process = IO.popen(command_args)
6464
@stdout = File.open(@logfile, "r")
6565

6666
while true
@@ -77,7 +77,7 @@ def start(options = {})
7777
return
7878
end
7979
if line.strip == "Press Ctrl-C to exit"
80-
#@pid = @process.pid
80+
@pid = @process.pid
8181
@stdout.close
8282
break
8383
end
@@ -101,7 +101,7 @@ def stop
101101
Process.kill("TERM", @pid)
102102
# sleep 3
103103
# Process.kill("KILL", @pid)
104-
# @process.close
104+
@process.close
105105
puts "Closed"
106106
puts `ps aux| grep BrowserStackLocal`
107107
puts `lsof -i:45691`
@@ -113,6 +113,10 @@ def stop
113113
def command
114114
"#{@binary_path} -logFile '#{@logfile}' #{@folder_flag} #{@key} #{@folder_path} #{@force_local_flag} #{@local_identifier_flag} #{@only_flag} #{@only_automate_flag} #{@proxy_host} #{@proxy_port} #{@proxy_user} #{@proxy_pass} #{@force_flag} #{@verbose_flag} #{@hosts}".strip
115115
end
116+
117+
def command_args
118+
["#{@binary_path}", "-logFile", "#{@logfile}", "#{@key}", "#{@folder_flag}", "#{@folder_path}", "#{@force_local_flag}", "#{@local_identifier_flag}", "#{@only_flag}", "#{@only_automate_flag}", "#{@proxy_host}", "#{@proxy_port}", "#{@proxy_user}", "#{@proxy_pass}", "#{@force_flag}", "#{@verbose_flag}", "#{@hosts}", :err => [:child, :out]]
119+
end
116120
end
117121

118122
end

0 commit comments

Comments
 (0)