Skip to content

Commit 1a9d20f

Browse files
committed
show filename only if there are multiple paths
1 parent 9e6b437 commit 1a9d20f

File tree

2 files changed

+26
-8
lines changed

2 files changed

+26
-8
lines changed

bin/cli.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,14 @@ function cleanUp(signal) {
6464
}
6565
}
6666

67+
function getTestBrowserInfo(browserString, path) {
68+
var info = browserString;
69+
if(config.multipleTest) {
70+
info += ", " + path;
71+
}
72+
return info;
73+
}
74+
6775
function launchServer() {
6876
logger.debug("Launching server on port:", serverPort);
6977

@@ -74,7 +82,7 @@ function launchServer() {
7482
function launchBrowser(browser, path) {
7583
var url = 'http://localhost:' + serverPort.toString() + '/' + path;
7684
var browserString = utils.browserString(browser);
77-
logger.debug("[%s] [%s] Launching", browserString, path);
85+
logger.debug("[%s] Launching", getTestBrowserInfo(browserString, path));
7886

7987
var key = utils.uuid();
8088

@@ -129,10 +137,12 @@ function launchBrowser(browser, path) {
129137
function launchBrowsers(config, browser) {
130138
setTimeout(function () {
131139
if(Object.prototype.toString.call(config.test_path) === '[object Array]'){
140+
config.multipleTest = config.test_path.length > 1? true : false;
132141
config.test_path.forEach(function(path){
133142
launchBrowser(browser, path);
134143
});
135144
} else {
145+
config.multipleTest = false;
136146
launchBrowser(browser, config.test_path);
137147
}
138148
}, 100);
@@ -157,7 +167,7 @@ var statusPoller = {
157167

158168
if (_worker.status === 'running') {
159169
//clearInterval(statusPoller);
160-
logger.debug('[%s] [%s] Launched', worker.string, worker.test_path);
170+
logger.debug('[%s] Launched', getTestBrowserInfo(worker.string, worker.test_path));
161171
worker.launched = true;
162172
workerData.marked = true;
163173

lib/server.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,14 @@ var mimeTypes = {
2020
"css": "text/css"
2121
};
2222

23+
function getTestBrowserInfo(worker) {
24+
var info = worker.string;
25+
if(config.multipleTest) {
26+
info += ", " + worker.test_path
27+
}
28+
return info;
29+
}
30+
2331

2432
exports.Server = function Server(bsClient, workers) {
2533

@@ -30,7 +38,7 @@ exports.Server = function Server(bsClient, workers) {
3038
if (query._worker_key && workers[query._worker_key]) {
3139
worker = workers[query._worker_key] || {};
3240
worker.acknowledged = true;
33-
logger.debug("[%s] [%s] Acknowledged", query._browser_string, worker.test_path);
41+
logger.debug("[%s] Acknowledged", getTestBrowserInfo(worker));
3442
}
3543

3644
fs.exists(filename, function(exists) {
@@ -148,7 +156,7 @@ exports.Server = function Server(bsClient, workers) {
148156

149157
if (query.tracebacks) {
150158
query.tracebacks.forEach(function(traceback) {
151-
logger.info(chalk.red("[%s] [%s] Error:"), worker.string, worker.test_path, formatTraceback(traceback));
159+
logger.info(chalk.red("[%s] Error:"), getTestBrowserInfo(worker), formatTraceback(traceback));
152160
});
153161
}
154162
response.end();
@@ -166,28 +174,28 @@ exports.Server = function Server(bsClient, workers) {
166174
logger.info("[%s] Null response from remote Browser", request.headers['x-browser-string']);
167175
} else {
168176
if (query.tracebacks && query.tracebacks.length > 0) {
169-
logger.info(chalk["red"]("[%s] [%s] Tracebacks:"), request.headers['x-browser-string'], worker.test_path);
177+
logger.info(chalk["red"]("[%s] Tracebacks:"), getTestBrowserInfo(worker));
170178
query.tracebacks.forEach(function(traceback) {
171179
logger.info(traceback);
172180
});
173181
}
174182
var color = query.failed ? "red" : "green";
175-
logger.info(chalk[color]("[%s] [%s] Completed in %d milliseconds. %d of %d passed, %d failed."), request.headers['x-browser-string'], worker.test_path, query.runtime, query.passed, query.total, query.failed);
183+
logger.info(chalk[color]("[%s] Completed in %d milliseconds. %d of %d passed, %d failed."), getTestBrowserInfo(worker), query.runtime, query.passed, query.total, query.failed);
176184
config.status += query.failed;
177185
}
178186

179187
if (worker) {
180188
bsClient.takeScreenshot(worker.id, function(error, screenshot) {
181189
if (!error && screenshot.url) {
182-
logger.info('[%s] [%s] ' + chalk['yellow']('Screenshot') + ': %s', worker.string, worker.test_path, screenshot.url);
190+
logger.info('[%s] ' + chalk['yellow']('Screenshot') + ': %s', getTestBrowserInfo(worker), screenshot.url);
183191
}
184192

185193
bsClient.terminateWorker(worker.id, function() {
186194
if (!workers[uuid]) {
187195
return;
188196
}
189197

190-
logger.debug('[%s] [%s] Terminated', worker.string, worker.test_path);
198+
logger.debug('[%s] Terminated', getTestBrowserInfo(worker));
191199

192200
clearTimeout(workers[uuid].activityTimeout);
193201
delete workers[uuid];

0 commit comments

Comments
 (0)