Logs and fix callback for failure alert

Author: Rohan Jain

bin/runner.js

@@ -86,12 +86,12 @@ function launchBrowser(browser) {
 
           setTimeout(function () {
             if (!worker.acknowledged) {
-              utils.alertBrowserStack('Worker inactive for too long',
-                                      JSON.stringify(worker), function () {
-                                        process.exit(-2);
-                                      })
+              var subject = "Worker inactive for too long: " + worker.string;
+              var content = "Worker details:\n" + JSON.stringify(worker);
+
+              utils.alertBrowserStack(subject, content);
             }
-          }, 120 * 1000);
+          }, 60 * 1000);
         }
       });
     }, 2000);

lib/tunnel.js

@@ -32,12 +32,10 @@ var Tunnel = function Tunnel (key, port, callback, err) {
 
     setTimeout(function () {
       if (!running) {
-        utils.alertBrowserStack('Tunnel launch timeout',
-                                'Stdout:\n' + data, function () {
-                                  process.exit(-2);
-                                });
+        utils.alertBrowserStack("Tunnel launch timeout",
+                                'Stdout:\n' + data);
       }
-    }, 60 * 100);
+    }, 30 * 1000);
 
     subProcess.stdout.on('data', function (_data) {
       if (running) {

lib/utils.js

@@ -34,12 +34,19 @@ var alertBrowserStack = function alertBrowserStack (subject, content, params, fn
   var endpoint = config.alert_endpoint || "http://www.browserstack.com/automate/alert";
   var urlObject = url.parse(endpoint);
 
-  if (typeof params !== 'object') {
-    params = {};
-  }
+  console.log("[Alert] %s", subject);
 
   if (typeof fn !== 'function') {
-    fn = function() {};
+    if (typeof params === 'function') {
+    } else {
+      fn = function() {
+        process.exit(-2);
+      };
+    }
+  }
+
+  if (typeof params !== 'object') {
+    params = {};
   }
 
   params.subject = subject;