Merge pull request #43 from browserstack/code_refactor

rahulnwn · rahulnwn · commit ecdaf6021c41 · 2014-03-10T15:41:19.000+05:30
Code refactoring issue
diff --git a/lib/configParser.js b/lib/configParser.js
@@ -61,7 +61,7 @@ var ConfigParser = {
       browserObject.browser = browserData[0];
       if (browserData[lindex] && browserData[lindex].indexOf("+") == -1) {
         if (["current", "previous"].indexOf(browserData[1]) != -1) {
-          browserObject.browser_version = ConfigParser.setBrowserVersion(ConfigParser.bsBrowsers, browserObject, browserData[1]);
+          browserObject.browser_version = ConfigParser.setBrowserVersion(browserObject, browserData[1]);
         }
         else {
           browserObject.browser_version = browserData.slice(1, lindex + 1).join(".");

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ var ConfigParser = {`
`61`	`61`	`browserObject.browser = browserData[0];`
`62`	`62`	`if (browserData[lindex] && browserData[lindex].indexOf("+") == -1) {`
`63`	`63`	`if (["current", "previous"].indexOf(browserData[1]) != -1) {`
`64`		`- browserObject.browser_version = ConfigParser.setBrowserVersion(ConfigParser.bsBrowsers, browserObject, browserData[1]);`
	`64`	`+ browserObject.browser_version = ConfigParser.setBrowserVersion(browserObject, browserData[1]);`
`65`	`65`	`}`
`66`	`66`	`else {`
`67`	`67`	`browserObject.browser_version = browserData.slice(1, lindex + 1).join(".");`