Skip to content

Commit 12643d8

Browse files
committed
fix: updated authonization for revoke group access
1 parent b03c85f commit 12643d8

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

Access/group_helper.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,10 @@ def validate_group_access_create_request(group, auth_user):
743743
def revoke_user_access(user, access, revoker, decline_message):
744744
user_identity = user.get_active_identity(access.access_tag)
745745
user_identity.decline_non_approved_access_mapping(access, decline_message)
746-
revoke_request(user_identity.get_granted_access_mapping(access).first(), revoker)
746+
access_mapping = user_identity.get_granted_access_mapping(access).first()
747+
if not access_mapping:
748+
return False
749+
revoke_request(access_mapping, revoker)
747750

748751
def remove_member(request):
749752
try:
@@ -812,7 +815,7 @@ def revoke_access_from_group(request):
812815

813816
group = mapping.group
814817
auth_user = request.user
815-
if not (auth_user.user.has_permission("ALLOW_USER_OFFBOARD") and group.member_is_owner(auth_user.user)):
818+
if not (auth_user.user.has_permission("ALLOW_USER_OFFBOARD") or group.member_is_owner(auth_user.user)):
816819
return {"error": USER_UNAUTHORIZED_MESSAGE}
817820

818821
revoke_access_memberships = []

0 commit comments

Comments
 (0)