fix: fixing failing test cases

Author: Khushi-Sardhara

Access/tests/features/process_individual_request.feature

@@ -1,3 +1,5 @@
+""" Test for individual pending requests"""
+
 Scenario: No pending requests
           Given individual_pending_requests is empty
           When process_individual_requests is called

Access/tests/test_process_individual_request.py

@@ -7,6 +7,7 @@
     when,
 )
 
+
 import pytest
 from .. import accessrequest_helper
 import Access
@@ -16,46 +17,54 @@
 from django.db.models.query import QuerySet
 from datetime import datetime, timedelta
 
+
 @pytest.fixture
 def user(mocker):
     user = mocker.MagicMock()
     user.email = "[email protected]"
     user.user.username = "test-user"
     return user
 
+
 @pytest.fixture
 def context(mocker):
     context = mocker.MagicMock()
     return context
 
+
 @pytest.fixture
 def new_request(mocker):
     req = mocker.MagicMock()
-    # req.user.user = mocker.MagicMock(spec=Access.models.User)
-    # req.user.email = "[email protected]"
     return req
 
 
-
-@scenario('./features/process_individual_request.feature', 'Multiple pending requests for a club')
+@scenario(
+    "./features/process_individual_request.feature",
+    "Multiple pending requests for a club",
+)
 def test_multiple_pending_requests_for_a_club():
     """Multiple pending requests for a club."""
     pass
 
 
-@scenario('./features/process_individual_request.feature', 'Multiple pending requests for multiple clubs')
+@scenario(
+    "./features/process_individual_request.feature",
+    "Multiple pending requests for multiple clubs",
+)
 def test_multiple_pending_requests_for_multiple_clubs():
     """Multiple pending requests for multiple clubs."""
     pass
 
 
-@scenario('./features/process_individual_request.feature', 'No pending requests')
+@scenario("./features/process_individual_request.feature", "No pending requests")
 def test_no_pending_requests():
     """No pending requests."""
     pass
 
 
-@scenario('./features/process_individual_request.feature', 'Single pending request for a club')
+@scenario(
+    "./features/process_individual_request.feature", "Single pending request for a club"
+)
 def test_single_pending_request_for_a_club():
     """Single pending request for a club."""
     pass
@@ -73,25 +82,25 @@ def step_impl(context):
     context.club_id = "123"
 
 
-@given('individual_pending_requests contains a single pending request for a club')
-def step_impl(context,mocker):
+@given("individual_pending_requests contains a single pending request for a club")
+def step_impl(context, mocker):
     """individual_pending_requests contains a single pending request for a club."""
-    context.individual_pending_requests = [{
-        "requestId": "123_request_1",
-        "club_id": "123",
-        "userEmail": "[email protected]",
-        "accessReason": "test_reason",
-        "access_desc": "test_access_desc",
-        "access_tag": "access-tag-1",
-        "requested_on": datetime.now().isoformat(),
-        "accessCategory": "test_access_category",
-        "accessMeta": "test_access_meta"
-    }]
-
-    
-
-
-@given('individual_pending_requests contains multiple pending requests for a club')
+    context.individual_pending_requests = [
+        {
+            "requestId": "123_request_1",
+            "club_id": "123",
+            "userEmail": "[email protected]",
+            "accessReason": "test_reason",
+            "access_desc": "test_access_desc",
+            "access_tag": "access-tag-1",
+            "requested_on": datetime.now().isoformat(),
+            "accessCategory": "test_access_category",
+            "accessMeta": "test_access_meta",
+        }
+    ]
+
+
+@given("individual_pending_requests contains multiple pending requests for a club")
 def step_impl(context):
     """individual_pending_requests contains multiple pending requests for a club."""
     context.individual_pending_requests = [
@@ -103,7 +112,7 @@ def step_impl(context):
             "access_tag": "tag 1",
             "requested_on": datetime(2023, 5, 1, 10, 0, 0),
             "accessCategory": "category 1",
-            "accessMeta": "meta 1"
+            "accessMeta": "meta 1",
         },
         {
             "requestId": "123_2",
@@ -113,12 +122,14 @@ def step_impl(context):
             "access_tag": "tag 2",
             "requested_on": datetime(2023, 5, 1, 11, 0, 0),
             "accessCategory": "category 2",
-            "accessMeta": "meta 2"
-        }
+            "accessMeta": "meta 2",
+        },
     ]
 
 
-@given('individual_pending_requests contains multiple pending requests for multiple clubs')
+@given(
+    "individual_pending_requests contains multiple pending requests for multiple clubs"
+)
 def step_impl(context):
     """individual_pending_requests contains multiple pending requests for multiple clubs."""
     context.individual_pending_requests = [
@@ -131,7 +142,7 @@ def step_impl(context):
             "access_tag": "access-tag-1",
             "requested_on": "2023-04-29T00:00:00Z",
             "accessCategory": "cat1",
-            "accessMeta": "meta1"
+            "accessMeta": "meta1",
         },
         {
             "requestId": "123_request2",
@@ -142,7 +153,7 @@ def step_impl(context):
             "access_tag": "access-tag-1",
             "requested_on": "2023-04-28T00:00:00Z",
             "accessCategory": "cat2",
-            "accessMeta": "meta2"
+            "accessMeta": "meta2",
         },
         {
             "requestId": "456_request1",
@@ -153,29 +164,32 @@ def step_impl(context):
             "access_tag": "access-tag-1",
             "requested_on": "2023-04-27T00:00:00Z",
             "accessCategory": "cat3",
-            "accessMeta": "meta3"
-        }
+            "accessMeta": "meta3",
+        },
     ]
 
 
-@given('individual_pending_requests is empty')
+@given("individual_pending_requests is empty")
 def step_impl(context):
     """individual_pending_requests is empty."""
     context.individual_pending_requests = []
     context.access_tag = "access-tag-1"
 
 
-@when('process_individual_requests is called')
-def step_impl(context,mocker):
+@when("process_individual_requests is called")
+def step_impl(context, mocker):
     """process_individual_requests is called."""
     context.individual_requests = []
     access_tag = context.access_tag
-    mocker.patch("Access.helpers.sla_breached",return_value=True)
-    accessrequest_helper.process_individual_requests(context.individual_pending_requests, context.individual_requests, access_tag)
-
+    mocker.patch("Access.helpers.sla_breached", return_value=True)
+    accessrequest_helper.process_individual_requests(
+        context.individual_pending_requests, context.individual_requests, access_tag
+    )
 
 
-@then('each entry should have club_id, userEmail, accessReason, accessType, requested_on, sla_breached, accessData')
+@then(
+    "each entry should have club_id, userEmail, accessReason, accessType, requested_on, sla_breached, accessData"
+)
 def step_impl(context):
     """each entry should have club_id, userEmail, accessReason, accessType, requested_on, sla_breached, accessData."""
     for request in context.individual_requests:
@@ -188,14 +202,18 @@ def step_impl(context):
             assert club_request["sla_breached"]
 
 
-@then('individual_requests should contain a single entry with module_tag "access-tag-1"')
+@then(
+    'individual_requests should contain a single entry with module_tag "access-tag-1"'
+)
 def step_impl(context):
     """individual_requests should contain a single entry with module_tag "access-tag-1"."""
     assert len(context.individual_requests) == 1
     assert context.individual_requests[0]["module_tag"] == "access-tag-1"
 
 
-@then('individual_requests should contain one entry for each club with module_tag "access-tag-1"')
+@then(
+    'individual_requests should contain one entry for each club with module_tag "access-tag-1"'
+)
 def step_impl(context):
     """individual_requests should contain one entry for each club with module_tag "access-tag-1"."""
     assert len(context.individual_requests[0]["requests"]) == 2
@@ -208,13 +226,15 @@ def step_impl(context):
         club_ids.remove(club_id)
 
 
-@then('individual_requests should remain unchanged')
+@then("individual_requests should remain unchanged")
 def step_impl(context):
     """individual_requests should remain unchanged."""
     assert len(context.individual_requests) == 0
 
 
-@then('the accessData for each entry should contain all the pending requests for the corresponding club.')
+@then(
+    "the accessData for each entry should contain all the pending requests for the corresponding club."
+)
 def step_impl(context):
     """the accessData for each entry should contain all the pending requests for the corresponding club.."""
     for request in context.individual_requests:
@@ -223,17 +243,23 @@ def step_impl(context):
             access_data = club_request["accessData"]
             for pending_request in context.individual_pending_requests:
                 if pending_request["club_id"] == club_id:
-                    assert len(pending_request)== 9
-                    
+                    assert len(pending_request) == 9
+
             assert len(context.individual_pending_requests) == 3
-                    
 
-@then('the accessData should contain all the pending requests for the club')
+
+@then("the accessData should contain all the pending requests for the club")
 def step_impl(context):
     """the accessData should contain all the pending requests for the club."""
     assert len(context.individual_requests[0]["requests"][0]["accessData"]) == 2
-    assert context.individual_requests[0]["requests"][0]["accessData"][0]["requestId"] == "123_1"
-    assert context.individual_requests[0]["requests"][0]["accessData"][1]["requestId"] == "123_2"
+    assert (
+        context.individual_requests[0]["requests"][0]["accessData"][0]["requestId"]
+        == "123_1"
+    )
+    assert (
+        context.individual_requests[0]["requests"][0]["accessData"][1]["requestId"]
+        == "123_2"
+    )
 
 
 @then('the entry should have club_id "123"')
@@ -242,8 +268,9 @@ def step_impl(context):
     assert context.individual_requests[0]["requests"][0]["club_id"] == "123"
 
 
-
-@then('the entry should have userEmail, accessReason, accessType, requested_on, sla_breached, accessData')
+@then(
+    "the entry should have userEmail, accessReason, accessType, requested_on, sla_breached, accessData"
+)
 def step_impl(context):
     """the entry should have userEmail, accessReason, accessType, requested_on, sla_breached, accessData."""
     request = context.individual_requests[0]["requests"][0]
@@ -257,4 +284,3 @@ def step_impl(context):
     assert request["accessData"][0]["accessCategory"] == "test_access_category"
     assert request["accessData"][0]["accessMeta"] == "test_access_meta"
     assert request["accessData"][0]["requestId"] == "123_request_1"
-