fix: fixing failing test cases

Author: Khushi-Sardhara

Access/tests/features/validate_approver_permissions.feature

@@ -27,7 +27,7 @@ Feature: Validate Approver Permission
         Then Return value should be empty json
 
     Scenario: User who made the request has primary approver access & access_mapping is not in pending state & module supports secondary approval 
-        Given User who made request has primary approver access
+        Given User who made request has primary approver access with false response
         And access_mapping is not in pending state
         And Modules supports secondary approval
         When validate_approver_permissions function is called
@@ -49,10 +49,10 @@ Feature: Validate Approver Permission
         Then Return value should be empty json
 
     Scenario: When the user who made the request has secondary approver access & access_mapping is in primary pending state & module does needs secondary approval 
-        Given User who made request has secondary approver access
+        Given User who made request has only secondary approver access with false response
         And access_mapping is in pending state
         And Modules does not need secondary approval
         When validate_approver_permissions function is called 
         Then Return value should be permission denied json
-
+        
 

Access/tests/test_validate_approver_permission.py

@@ -120,27 +120,48 @@ def step_impl(access_mapping):
 
 
 @given("User who made request has primary approver access")
-def step_impl(context, mocker, access_mapping):
+def step_impl(context, mocker, access_mapping,request_1):
     """User who made request has primary approver access."""
-    mock_permissions = {"approver_permissions": {"1": "ACCESS_APPROVE"}}
+    mock_permissions = {"approver_permissions": {"1": "ACCESS_APPROVE","2":""}}
     mocker.patch(
         "Access.accessrequest_helper._get_approver_permissions",
         return_value=mock_permissions,
     )
+    request_1.user.user.has_permission.return_value = True
+
+@given("User who made request has primary approver access with false response")
+def step_impl(context, mocker, access_mapping,request_1):
+    """User who made request has primary approver access."""
+    mock_permissions = {"approver_permissions": {"1": "ACCESS_APPROVE","2":""}}
+    mocker.patch(
+        "Access.accessrequest_helper._get_approver_permissions",
+        return_value=mock_permissions,
+    )
+    request_1.user.user.has_permission.return_value = False
 
 
 @given("User who made request has secondary approver access")
-def step_impl(mocker, context, access_mapping):
-    mock_permissions = {"approver_permissions": {"2": "ACCESS_APPROVE"}}
+def step_impl(mocker, context, access_mapping,request_1):
+    mock_permissions = {"approver_permissions": {"1": "","2": "ACCESS_APPROVE"}}
     mocker.patch(
         "Access.accessrequest_helper._get_approver_permissions",
         return_value=mock_permissions,
     )
+    request_1.user.user.has_permission.return_value = True
+
+@given("User who made request has only secondary approver access with false response")
+def step_impl(mocker, context, access_mapping,request_1):
+    mock_permissions = {"approver_permissions": {"1": "","2": "ACCESS_APPROVE"}}
+    mocker.patch(
+        "Access.accessrequest_helper._get_approver_permissions",
+        return_value=mock_permissions,
+    )
+    request_1.user.user.has_permission.return_value = False
 
 
 @given("User who made request not have any approver access")
 def step_impl(mocker, request_1):
-    mock_permissions = {"approver_permissions": {"1": "ACCESS_APPROVE"}}
+    mock_permissions = {"approver_permissions": {"1":"","2":""}}
     mocker.patch(
         "Access.accessrequest_helper._get_approver_permissions",
         return_value=mock_permissions,