Skip to content

Commit 651b552

Browse files
committed
fix: ensure no duplicate modules while mounting and cloning
refactor: ensure error handling is consistent
1 parent d4fc93c commit 651b552

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Access/accessrequest_helper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def create_request(auth_user, access_request_form):
460460
request_id=request_id,
461461
access_reason=access_reason,
462462
)
463-
if access_create_error:
463+
if "title" not in access_create_error or access_create_error["title"] != "success":
464464
json_response["status_list"].append(access_create_error)
465465
continue
466466

@@ -521,7 +521,7 @@ def _create_access(
521521
)
522522
except Exception:
523523
return {
524-
"error_msg": REQUEST_DB_ERR_MSG["error_msg"],
524+
"title": REQUEST_DB_ERR_MSG["error_msg"],
525525
"msg": REQUEST_DB_ERR_MSG["msg"],
526526
}
527527
return {"title": "success", "msg": "success"}

docker-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ services:
1313
- ./secrets/ops_app_dev.env
1414
volumes:
1515
- ./:/srv/code/dev
16-
- ./mounts/modules:/srv/code/dev/Access/access_modules
16+
- ./mounts/modules_web:/srv/code/dev/Access/access_modules
1717
- ./mounts/db:/srv/code/dev/db
1818
- ./mounts/logs:/ebs/logs
1919
ports:
@@ -49,7 +49,7 @@ services:
4949
args:
5050
APPUID: ${APPUID}
5151
volumes:
52-
- ./mounts/modules:/srv/code/dev/Access/access_modules
52+
- ./mounts/modules_celery:/srv/code/dev/Access/access_modules
5353
- ./mounts/db:/srv/code/dev/db
5454
- ./mounts/logs:/ebs/logs
5555
env_file:

0 commit comments

Comments
 (0)