fix: user identity fixes

Author: niveshm

Access/accessrequest_helper.py

@@ -382,7 +382,7 @@ def create_request(auth_user, access_request_form):
     for index1, access_type in enumerate(access_request["accessRequests"]):
         access_labels = validate_access_labels(
             access_labels_json=access_request["accessLabel"][index1],
-            access_type=access_type,
+            access_tag=access_type,
         )
         access_reason = access_request["accessReason"][index1]
 

Access/userlist_helper.py

@@ -49,6 +49,9 @@ def get_identity_templates(auth_user):
     context["unconfigured_identity_template"] = []
     all_modules = helper.get_available_access_modules()
     for user_identity in user_identities:
+        if not all_modules[user_identity.access_tag].get_identity_template():
+            all_modules.pop(user_identity.access_tag)
+            continue
         is_identity_configured = _is_valid_identity_json(
             identity=user_identity.identity
         )
@@ -63,6 +66,11 @@ def get_identity_templates(auth_user):
             all_modules.pop(user_identity.access_tag)
 
     for mod in all_modules.values():
+        if not mod.get_identity_template():
+            auth_user.user.create_new_identity(
+                access_tag=mod.tag(), identity={}
+            )
+            continue
         context["unconfigured_identity_template"].append(
             {
                 "accessUserTemplatePath": mod.get_identity_template(),
@@ -94,12 +102,12 @@ def create_identity(user_identity_form, auth_user):
         existing_user_identity = user.get_active_identity(
             access_tag=selected_access_module.tag()
         )
-        if new_module_identity_json == existing_user_identity.identity:
-            raise IdentityNotChangedException()
         existing_user_access_mapping = None
 
         # get useraccess if an identity already exists
         if existing_user_identity:
+            if new_module_identity_json == existing_user_identity.identity:
+                raise IdentityNotChangedException()
             existing_user_access_mapping = (
                 existing_user_identity.get_active_access_mapping()
             )
@@ -142,19 +150,20 @@ def __change_identity_and_transfer_access_mapping(
     )
     # replicate the memberships with new identity
     new_user_access_mapping = []
-    if existing_user_access_mapping:
-        new_user_access_mapping = (
-            new_user_identity.replicate_active_access_membership_for_module(
-                existing_access=existing_user_access_mapping
+    if existing_user_identity:
+        if existing_user_access_mapping:
+            new_user_access_mapping = (
+                new_user_identity.replicate_active_access_membership_for_module(
+                    existing_access=existing_user_access_mapping
+                )
             )
-        )
-    system_user = User.get_system_user()
+        system_user = User.get_system_user()
 
-    for mapping in existing_user_access_mapping:
-        if mapping.is_approved():
-            revoke_request(user_access_mapping=mapping, revoker=system_user)
+        for mapping in existing_user_access_mapping:
+            if mapping.is_approved():
+                revoke_request(user_access_mapping=mapping, revoker=system_user)
 
-    existing_user_identity.decline_all_non_approved_access_mappings("Identity Updated")
+        existing_user_identity.decline_all_non_approved_access_mappings("Identity Updated")
 
     for mapping in new_user_access_mapping:
         if mapping.is_processing() or mapping.is_grantfailed():

templates/updateUser.html

@@ -72,7 +72,7 @@ <h2 class="h5 no-margin-bottom">Update User Info: {{request.user}}</h2>
       $('#' + formId).find('#success-msg').text("")
       error_message = "There was an error in updating User Identity for module " + modName + ". Please contact Admin"
       $.ajax({
-          url : "{% url 'saveIdentity' %}/", // the endpoint
+          url : "{% url 'saveIdentity' %}", // the endpoint
           type : "POST", // http method
           data : $('#' + formId).serialize(),