Refactor: Improve consistency in MCP event

Author: tech-sushant

src/lib/instrumentation.ts

@@ -18,12 +18,12 @@ interface MCPEventPayload {
 export function trackMCP(
   toolName: string,
   clientInfo: { name?: string; version?: string },
-  error?: unknown
+  error?: unknown,
 ): void {
   const instrumentationEndpoint = "https://api.browserstack.com/sdk/v1/event";
   const isSuccess = !error;
   const mcpClient = clientInfo?.name || "unknown";
-  
+
   // Log client information
   if (clientInfo?.name) {
     logger.info(
@@ -45,8 +45,10 @@ export function trackMCP(
 
   // Add error details if applicable
   if (error) {
-    event.event_properties.error_message = error instanceof Error ? error.message : String(error);
-    event.event_properties.error_type = error instanceof Error ? error.constructor.name : "Unknown";
+    event.event_properties.error_message =
+      error instanceof Error ? error.message : String(error);
+    event.event_properties.error_type =
+      error instanceof Error ? error.constructor.name : "Unknown";
   }
 
   axios
@@ -60,17 +62,20 @@ export function trackMCP(
       timeout: 2000,
     })
     .then((response) => {
-      logger.info(`MCP ${isSuccess ? 'event' : 'failure event'} tracked successfully`, {
-        toolName,
-        response,
-      });
+      logger.info(
+        `MCP ${isSuccess ? "event" : "failure event"} tracked successfully`,
+        {
+          toolName,
+          response,
+        },
+      );
     })
     .catch((error: unknown) => {
       logger.warn(
-        `Failed to track MCP ${isSuccess ? 'event' : 'failure event'}: ${error instanceof Error ? error.message : String(error)}`,
+        `Failed to track MCP ${isSuccess ? "event" : "failure event"}: ${error instanceof Error ? error.message : String(error)}`,
         {
           toolName,
         },
       );
     });
-}
+}

src/tools/accessibility.ts

@@ -44,16 +44,13 @@ export default function addAccessibilityTools(server: McpServer) {
     },
     async (args) => {
       try {
-        trackMCP(
-          "startAccessibilityScan",
-          server.server.getClientVersion()!
-        );
+        trackMCP("startAccessibilityScan", server.server.getClientVersion()!);
         return await runAccessibilityScan(args.name, args.pageURL);
       } catch (error) {
         trackMCP(
           "startAccessibilityScan",
           server.server.getClientVersion()!,
-          error
+          error,
         );
         return {
           content: [

src/tools/applive.ts

@@ -95,11 +95,7 @@ export default function addAppLiveTools(server: McpServer) {
         return await startAppLiveSession(args);
       } catch (error) {
         logger.error("App live session failed: %s", error);
-        trackMCP(
-          "runAppLiveSession",
-          server.server.getClientVersion()!,
-          error
-        );
+        trackMCP("runAppLiveSession", server.server.getClientVersion()!, error);
         return {
           content: [
             {

src/tools/automate.ts

@@ -58,7 +58,7 @@ export default function addAutomateTools(server: McpServer) {
         trackMCP(
           "getNetworkFailures",
           server.server.getClientVersion()!,
-          error
+          error,
         );
 
         return {

src/tools/bstack-sdk.ts

@@ -74,10 +74,7 @@ export default function addSDKTools(server: McpServer) {
     },
     async (args) => {
       try {
-        trackMCP(
-          "runTestsOnBrowserStack",
-          server.server.getClientVersion()!
-        );
+        trackMCP("runTestsOnBrowserStack", server.server.getClientVersion()!);
 
         return await bootstrapProjectWithSDK({
           detectedBrowserAutomationFramework:
@@ -91,7 +88,7 @@ export default function addSDKTools(server: McpServer) {
         trackMCP(
           "runTestsOnBrowserStack",
           server.server.getClientVersion()!,
-          error
+          error,
         );
         return {
           content: [

src/tools/live.ts

@@ -105,17 +105,14 @@ export default function addBrowserLiveTools(server: McpServer) {
     LiveArgsShape,
     async (args) => {
       try {
-        trackMCP(
-          "runBrowserLiveSession",
-          server.server.getClientVersion()!
-        );
+        trackMCP("runBrowserLiveSession", server.server.getClientVersion()!);
         return await runBrowserSession(args);
       } catch (error) {
         logger.error("Live session failed: %s", error);
         trackMCP(
           "runBrowserLiveSession",
           server.server.getClientVersion()!,
-          error
+          error,
         );
         return {
           content: [

src/tools/observability.ts

@@ -59,17 +59,14 @@ export default function addObservabilityTools(server: McpServer) {
     },
     async (args) => {
       try {
-        trackMCP(
-          "getFailuresInLastRun",
-          server.server.getClientVersion()!
-        );
+        trackMCP("getFailuresInLastRun", server.server.getClientVersion()!);
         return await getFailuresInLastRun(args.buildName, args.projectName);
       } catch (error) {
         logger.error("Failed to get failures in the last run: %s", error);
         trackMCP(
           "getFailuresInLastRun",
           server.server.getClientVersion()!,
-          error
+          error,
         );
         return {
           content: [

src/tools/testmanagement.ts

@@ -25,15 +25,15 @@ export async function createProjectOrFolderTool(
   try {
     trackMCP(
       "createProjectOrFolder",
-      serverInstance.server.getClientVersion()!
+      serverInstance.server.getClientVersion()!,
     );
     return await createProjectOrFolder(args);
   } catch (err) {
     logger.error("Failed to create project/folder: %s", err);
     trackMCP(
       "createProjectOrFolder",
       serverInstance.server.getClientVersion()!,
-      err
+      err,
     );
     return {
       content: [
@@ -63,11 +63,7 @@ export async function createTestCaseTool(
     return await createTestCaseAPI(cleanedArgs);
   } catch (err) {
     logger.error("Failed to create test case: %s", err);
-    trackMCP(
-      "createTestCase",
-      serverInstance.server.getClientVersion()!,
-      err
-    );
+    trackMCP("createTestCase", serverInstance.server.getClientVersion()!, err);
     return {
       content: [
         {

tests/tools/applive.test.ts

@@ -16,8 +16,7 @@ jest.mock('../../src/logger', () => ({
   error: jest.fn()
 }));
 jest.mock('../../src/lib/instrumentation', () => ({
-  trackMCPEvent: jest.fn(),
-  trackMCPFailure: jest.fn()
+  trackMCP: jest.fn()
 }));
 
 describe('startAppLiveSession', () => {

tests/tools/automate.test.ts

@@ -6,8 +6,7 @@ jest.mock('../../src/lib/api', () => ({
   retrieveNetworkFailures: jest.fn()
 }));
 jest.mock('../../src/lib/instrumentation', () => ({
-  trackMCPEvent: jest.fn(),
-  trackMCPFailure: jest.fn()
+  trackMCP: jest.fn()
 }));
 jest.mock('../../src/logger', () => ({
   error: jest.fn(),