Suggested fixes around readability

Author: tech-sushant

src/lib/local.ts

@@ -81,13 +81,22 @@ export async function ensureLocalBinarySetup(localIdentifier?: string): Promise<
   const localBinary = new Local();
   await killExistingBrowserStackLocalProcesses();
 
+  const requestBody: {
+    key: string;
+    username: string;
+    localIdentifier?: string;
+  } = {
+    key: config.browserstackAccessKey,
+    username: config.browserstackUsername
+  };
+
+  if (localIdentifier) {
+    requestBody.localIdentifier = localIdentifier;
+  }
+
   return await new Promise((resolve, reject) => {
     localBinary.start(
-      {
-        key: config.browserstackAccessKey,
-        username: config.browserstackUsername,
-        ...(localIdentifier ? { localIdentifier } : {}),
-      },
+      requestBody,
       (error?: Error) => {
         if (error) {
           logger.error(

src/tools/accessiblity-utils/scanner.ts

@@ -33,7 +33,8 @@ export class AccessibilityScanner {
     // Check if any URL is local
     const hasLocal = urlList.some(isLocalURL);
     const localIdentifier = crypto.randomUUID();
-    const localHosts = new Set(["127.0.0.1", "localhost"]);
+    const LOCAL_IP = "127.0.0.1";
+    const BS_LOCAL_DOMAIN = "bs-local.com";
 
     if (hasLocal) {
       await ensureLocalBinarySetup(localIdentifier);
@@ -44,8 +45,8 @@ export class AccessibilityScanner {
     const transformedUrlList = urlList.map((url) => {
       try {
         const parsed = new URL(url);
-        if (localHosts.has(parsed.hostname)) {
-          parsed.hostname = "bs-local.com";
+        if (parsed.hostname === LOCAL_IP) {
+          parsed.hostname = BS_LOCAL_DOMAIN;
           return parsed.toString();
         }
         return url;
@@ -55,21 +56,23 @@ export class AccessibilityScanner {
       }
     });
 
-    const requestBody = {
+    const baseRequestBody = {
       name,
       urlList: transformedUrlList,
       recurring: false,
-      ...(hasLocal
-        ? {
-            local: true,
-            localTestingInfo: {
-              localIdentifier: localIdentifier,
-              localEnabled: true,
-            },
-          }
-        : {}),
     };
 
+    let requestBody = baseRequestBody;
+    if (hasLocal) {
+      const localConfig = {
+        localTestingInfo: {
+          localIdentifier,
+          localEnabled: true,
+        }
+      };
+      requestBody = { ...baseRequestBody, ...localConfig };
+    }
+
     try {
       const { data } = await axios.post<AccessibilityScanResponse>(
         "https://api-accessibility.browserstack.com/api/website-scanner/v1/scans",