Modularity ++

Author: tech-sushant

src/tools/percy-snapshot-utils/constants.ts

@@ -480,3 +480,35 @@ export const EXCLUDED_DIRS = new Set([
   "packages",
   ".nuget",
 ]);
+
+export const backendIndicators = [
+  /import\s+requests/,
+  /requests\.(get|post|put|delete|patch)/,
+  /@pytest\.mark\.(api|backend|integration)/,
+  /BASE_URL\s*=/,
+  /\.status_code/,
+  /\.json\(\)/,
+  /TestClient/,
+  /Bearer\s+/,
+  /Authorization.*Bearer/,
+];
+
+export const strongUIIndicators = [
+  // Browser automation with specific context
+  /(driver|browser|page)\.(click|type|fill|screenshot|wait)/,
+  /webdriver\.(Chrome|Firefox|Safari|Edge)/,
+  /(selenium|playwright|puppeteer|cypress).*import/,
+  // CSS/XPath selectors
+  /By\.(ID|CLASS_NAME|XPATH|CSS_SELECTOR)/,
+  /\$\(['"#[.][^'"]*['"]\)/, // $(".class") or $("#id")
+  // Page Object Model
+  /class.*Page.*:/,
+  /class.*PageObject/,
+  // UI test markers
+  /@(ui|web|e2e|browser)_?test/,
+  /@pytest\.mark\.(ui|web|e2e|browser)/,
+  // Browser navigation
+  /\.goto\s*\(['"]https?:/,
+  /\.visit\s*\(['"]https?:/,
+  /\.navigate\(\)\.to\(/,
+];

src/tools/percy-snapshot-utils/detect-test-files.ts

@@ -10,6 +10,8 @@ import {
 import {
   EXCLUDED_DIRS,
   TEST_FILE_DETECTION,
+  backendIndicators,
+  strongUIIndicators,
 } from "../percy-snapshot-utils/constants.js";
 
 import { DetectionConfig } from "../percy-snapshot-utils/types.js";
@@ -70,45 +72,9 @@ async function batchRegexCheck(
 async function isLikelyUITest(filePath: string): Promise<boolean> {
   try {
     const content = await fs.promises.readFile(filePath, "utf8");
-
-    // Quick backend test elimination
-    const backendIndicators = [
-      /import\s+requests/,
-      /requests\.(get|post|put|delete|patch)/,
-      /@pytest\.mark\.(api|backend|integration)/,
-      /BASE_URL\s*=/,
-      /\.status_code/,
-      /\.json\(\)/,
-      /TestClient/,
-      /Bearer\s+/,
-      /Authorization.*Bearer/,
-    ];
-
     if (backendIndicators.some((pattern) => pattern.test(content))) {
       return false;
     }
-
-    // UI-specific patterns that require context
-    const strongUIIndicators = [
-      // Browser automation with specific context
-      /(driver|browser|page)\.(click|type|fill|screenshot|wait)/,
-      /webdriver\.(Chrome|Firefox|Safari|Edge)/,
-      /(selenium|playwright|puppeteer|cypress).*import/,
-      // CSS/XPath selectors
-      /By\.(ID|CLASS_NAME|XPATH|CSS_SELECTOR)/,
-      /\$\(['"#[.][^'"]*['"]\)/, // $(".class") or $("#id")
-      // Page Object Model
-      /class.*Page.*:/,
-      /class.*PageObject/,
-      // UI test markers
-      /@(ui|web|e2e|browser)_?test/,
-      /@pytest\.mark\.(ui|web|e2e|browser)/,
-      // Browser navigation
-      /\.goto\s*\(['"]https?:/,
-      /\.visit\s*\(['"]https?:/,
-      /\.navigate\(\)\.to\(/,
-    ];
-
     return strongUIIndicators.some((pattern) => pattern.test(content));
   } catch {
     return false;