refactor: update params and improve descriptions

Author: tech-sushant

src/tools/rca-agent-utils/constants.ts

@@ -11,15 +11,15 @@ export const FETCH_RCA_PARAMS = {
 };
 
 export const GET_BUILD_ID_PARAMS = {
-  projectName: z
+  browserStackProjectName: z
     .string()
     .describe(
-      "The Browserstack project name used while creation of test run. Check browserstack.yml or similar project configuration files. If found extract it and provide to user, IF not found or unsure, prompt the user for this value. Do not make assumptions",
+      "The BrowserStack project name used during test run creation. Action: First, check browserstack.yml or any equivalent project configuration files. If the project name is found, extract and return it. If it is not found or if there is any uncertainty, immediately prompt the user to provide the value. Do not infer, guess, or assume a default.",
     ),
-  buildName: z
+  browserStackBuildName: z
     .string()
     .describe(
-      "The Browserstack build name used while creation of test run. Check browserstack.yml or similar project configuration files. If found extract it and provide to user, IF not found or unsure, prompt the user for this value. Do not make assumptions",
+      "The BrowserStack build name used during test run creation. Action: First, check browserstack.yml or any equivalent project configuration files. If the build name is found, extract and return it. If it is not found or if there is any uncertainty, immediately prompt the user to provide the value. Do not infer, guess, or assume a default.",
     ),
 };
 

src/tools/rca-agent-utils/get-failed-test-id.ts

@@ -36,22 +36,25 @@ export async function getTestIds(
 
       // Extract failed IDs from current page
       if (data.hierarchy && data.hierarchy.length > 0) {
-        const currentFailedTests = extractFailedTestIds(data.hierarchy);
+        const currentFailedTests = extractFailedTestIds(data.hierarchy, status);
         allFailedTests = allFailedTests.concat(currentFailedTests);
       }
 
       // Check for pagination termination conditions
-      if (!data.pagination?.has_next || !data.pagination.next_page) {
+      if (
+        !data.pagination?.has_next ||
+        !data.pagination.next_page ||
+        requestNumber >= 5
+      ) {
         break;
       }
 
-      // Safety limit to prevent runaway requests
-      if (requestNumber >= 5) {
-        break;
-      }
+      const params: Record<string, string> = {
+        next_page: data.pagination.next_page,
+      };
+      if (status) params.test_statuses = status;
 
-      // Prepare next request
-      url = `${baseUrl}?next_page=${encodeURIComponent(data.pagination.next_page)}`;
+      url = `${baseUrl}?${new URLSearchParams(params).toString()}`;
     }
 
     // Return unique failed test IDs
@@ -63,11 +66,14 @@ export async function getTestIds(
 }
 
 // Recursive function to extract failed test IDs from hierarchy
-function extractFailedTestIds(hierarchy: TestDetails[]): FailedTestInfo[] {
+function extractFailedTestIds(
+  hierarchy: TestDetails[],
+  status?: TestStatus,
+): FailedTestInfo[] {
   let failedTests: FailedTestInfo[] = [];
 
   for (const node of hierarchy) {
-    if (node.details?.status === "failed" && node.details?.run_count) {
+    if (node.details?.status === status && node.details?.run_count) {
       if (node.details?.observability_url) {
         const idMatch = node.details.observability_url.match(/details=(\d+)/);
         if (idMatch) {
@@ -80,7 +86,9 @@ function extractFailedTestIds(hierarchy: TestDetails[]): FailedTestInfo[] {
     }
 
     if (node.children && node.children.length > 0) {
-      failedTests = failedTests.concat(extractFailedTestIds(node.children));
+      failedTests = failedTests.concat(
+        extractFailedTestIds(node.children, status),
+      );
     }
   }
 

src/tools/rca-agent-utils/types.ts

@@ -48,3 +48,8 @@ export interface RCATestCase {
 export interface RCAResponse {
   testCases: RCATestCase[];
 }
+
+export interface BuildIdArgs {
+  browserStackProjectName: string;
+  browserStackBuildName: string;
+}

src/tools/rca-agent.ts

@@ -10,6 +10,7 @@ import { formatRCAData } from "./rca-agent-utils/format-rca.js";
 import { TestStatus } from "./rca-agent-utils/types.js";
 import { handleMCPError } from "../lib/utils.js";
 import { trackMCP } from "../index.js";
+import { BuildIdArgs } from "./rca-agent-utils/types.js";
 import {
   FETCH_RCA_PARAMS,
   GET_BUILD_ID_PARAMS,
@@ -18,22 +19,22 @@ import {
 
 // Tool function to fetch build ID
 export async function getBuildIdTool(
-  args: {
-    projectName: string;
-    buildName: string;
-  },
+  args: BuildIdArgs,
   config: BrowserStackConfig,
 ): Promise<CallToolResult> {
   try {
-    const { projectName, buildName } = args;
+    const { browserStackProjectName, browserStackBuildName } = args;
+
     const authString = getBrowserStackAuth(config);
     const [username, accessKey] = authString.split(":");
+
     const buildId = await getBuildId(
-      projectName,
-      buildName,
+      browserStackProjectName,
+      browserStackBuildName,
       username,
       accessKey,
     );
+
     return {
       content: [
         {