refactor: introduce DEFAULT_MOBILE_DEVICE for improved device handling in App Automate tools

Author: tech-sushant

src/tools/appautomate-utils/appium-sdk/handler.ts

@@ -5,6 +5,7 @@ import { getBrowserStackAuth } from "../../../lib/get-auth.js";
 import {
   validateAppAutomateDevices,
   convertMobileDevicesToTuples,
+  DEFAULT_MOBILE_DEVICE,
 } from "../../sdk-utils/common/device-validator.js";
 
 import {
@@ -48,11 +49,10 @@ export async function setupAppAutomateHandler(
   validateSupportforAppAutomate(framework, language, testingFramework);
 
   // Convert device objects to tuples for validator
-  const inputDevices = input.devices || [];
   const devices: Array<Array<string>> =
-    inputDevices.length === 0
-      ? [["android", "Samsung Galaxy S24", "latest"]]
-      : convertMobileDevicesToTuples(inputDevices);
+    input.devices.length === 0
+      ? DEFAULT_MOBILE_DEVICE
+      : convertMobileDevicesToTuples(input.devices);
 
   // Validate devices against real BrowserStack device data
   const validatedEnvironments = await validateAppAutomateDevices(devices);

src/tools/appautomate.ts

@@ -12,6 +12,7 @@ import { setupAppAutomateHandler } from "./appautomate-utils/appium-sdk/handler.
 import {
   validateAppAutomateDevices,
   convertMobileDevicesToTuples,
+  DEFAULT_MOBILE_DEVICE,
 } from "./sdk-utils/common/device-validator.js";
 
 import {
@@ -383,9 +384,9 @@ export default function addAppAutomationTools(
         );
         // Convert device objects to tuples for the handler
         const devices: Array<Array<string>> =
-          (args.devices || []).length === 0
-            ? [["android", "Samsung Galaxy S24", "latest"]]
-            : convertMobileDevicesToTuples(args.devices || []);
+          args.devices.length === 0
+            ? DEFAULT_MOBILE_DEVICE
+            : convertMobileDevicesToTuples(args.devices);
         return await runAppTestsOnBrowserStack(
           { ...args, devices },
           config,

src/tools/sdk-utils/common/device-validator.ts

@@ -72,6 +72,11 @@ const DEFAULTS = {
   ios: { device: "iPhone 15", browser: "safari" },
 } as const;
 
+// Default mobile device tuple for App Automate when no devices are provided
+export const DEFAULT_MOBILE_DEVICE: Array<Array<string>> = [
+  ["android", "Samsung Galaxy S24", "latest"],
+];
+
 // Performance optimization: Indexed maps for faster lookups
 interface DesktopIndex {
   byOS: Map<string, DesktopBrowserEntry[]>;