Minor PR Comments, moved protocolRegex to constants file

Author: Arihant Jain

config/constants.js

@@ -10,6 +10,7 @@ module.exports.PORTS = {
   MAX: 65535,
   MIN: 1
 };
+module.exports.PROTOCOL_REGEX = /(^\w+:|^)\/\//;
 
 module.exports.LOGS = Object.freeze({
   NETWORK: 'NetworkStats.log',

src/commandLine.js

@@ -119,11 +119,11 @@ var CommandLineManager = {
     index = argv.indexOf('--proxy-host');
     if (index !== -1) {
       if (CommandLineManager.validArgValue(argv[index + 1])) {
-        var hostRegex = /(^\w+:|^)\/\//;
         var host = argv[index + 1];
-        if (host.match(hostRegex)) {
-          host = host.replace(/(^\w+:|^)\/\//, '');
+        if (host.match(constants.PROTOCOL_REGEX)) {
+          host = host.replace(constants.PROTOCOL_REGEX, '');
         }
+        console.log(host);
         RdGlobalConfig.proxy = RdGlobalConfig.proxy || {};
         RdGlobalConfig.proxy.host = host;
         argv.splice(index, 2);

test/commandLine.test.js

@@ -31,13 +31,25 @@ describe('CommandLineManager', function () {
 
     it('parse proxy-host and proxy-port params', function () {
       sinon.stub(console, 'log');
-      argv = argv.concat(['--proxy-host', 'http://host', '--proxy-port', '9687']);
+      argv = argv.concat(['--proxy-host', 'host', '--proxy-port', '9687']);
       CommandLineManager.processArgs(argv);
       console.log.restore();
       expect(RdGlobalConfig.proxy.host).to.eql('host');
       expect(RdGlobalConfig.proxy.port).to.eql(9687);
     });
 
+    it('remove any protocal part from proxy-host', function () {
+      sinon.stub(console, 'log');
+      argv = argv.concat(['--proxy-host', 'http://host']);
+      CommandLineManager.processArgs(argv);
+      expect(RdGlobalConfig.proxy.host).to.eql('host');
+
+      argv = argv.concat(['--proxy-host', '//host']);
+      CommandLineManager.processArgs(argv);
+      console.log.restore();
+      expect(RdGlobalConfig.proxy.host).to.eql('host');
+    });
+
     it('proxy-port is set to the default value when its not in the expected range', function () {
       sinon.stub(console, 'log');
       argv = argv.concat(['--proxy-host', 'host', '--proxy-port', '99999']);