Skip to content

Commit d5fb569

Browse files
authored
Merge pull request #9 from Archish27/error_message
🎨 Added error message in logs
2 parents 7cea777 + 5b7c3e6 commit d5fb569

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

lib/core/Context.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ class Context extends EventEmitter {
9494
} else this.outgoingSocket.emit(kSendMessage, msg);
9595
});
9696

97-
this.incomingSocket.on(kError, () => {
98-
logger.error(`${INCOMING} [${this.connectionId}] [ERROR]`);
97+
this.incomingSocket.on(kError, (error) => {
98+
logger.error(`${INCOMING} [${this.connectionId}] [ERROR] ${error}`);
9999
incrErrorConnectionCount();
100100
});
101101

@@ -182,8 +182,8 @@ class Context extends EventEmitter {
182182
} else this.incomingSocket.emit(kSendMessage, msg);
183183
});
184184

185-
this.outgoingSocket.on(kError, () => {
186-
logger.error(`${OUTGOING} [${this.connectionId}] [ERROR]`);
185+
this.outgoingSocket.on(kError, (error) => {
186+
logger.error(`${OUTGOING} [${this.connectionId}] [ERROR] ${error}`);
187187
incrErrorConnectionCount();
188188
});
189189

lib/core/IncomingWebSocket.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ class IncomingWebSocket extends EventEmitter {
7777
/**
7878
* Triggers when error occured on socket.
7979
*/
80-
errorHandler() {
81-
this.emit(kError);
80+
errorHandler(error) {
81+
this.emit(kError, error);
8282
}
8383

8484
/**

lib/core/OutgoingWebSocket.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ class OutgoingWebSocket extends EventEmitter {
135135
/**
136136
* Triggers when error occured on socket.
137137
*/
138-
errorHandler() {
139-
this.emit(kError);
138+
errorHandler(error) {
139+
this.emit(kError, error);
140140
}
141141

142142
/**

test/core/incomingWebSocket.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ describe('IncomingWebSocket', () => {
156156
it('should emit kError once', () => {
157157
const emitSpy = spy();
158158
incomingWs.emit = emitSpy;
159-
incomingWs.errorHandler();
159+
incomingWs.errorHandler('SOME ERROR');
160160
assert(emitSpy.calledOnce);
161161
assert(emitSpy.calledWith(kError));
162162
});

test/core/outgoingWebSocket.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ describe('OutgoingWebSocket', () => {
224224
it('should emit kError', () => {
225225
const errSpy = spy();
226226
outgoingWs.emit = errSpy;
227-
outgoingWs.errorHandler();
227+
outgoingWs.errorHandler('SOME ERROR');
228228
assert(errSpy.calledOnce);
229229
});
230230
});

0 commit comments

Comments
 (0)