🐛 fix for alert manager send alert function

Author: Archish27

lib/util/AlertManager.js

@@ -8,7 +8,7 @@ class AlertManager {
    * Creates the AlertManager.
    */
   constructor() {
-    this.sendAlerts = this.sendAlerts.bind(this);
+    this.sendAlert = this.sendAlert.bind(this);
   }
 
   /**
@@ -19,7 +19,7 @@ class AlertManager {
    * @param {String} subject
    * @param {String} message
    */
-  sendAlerts(subject, message) {
+  sendAlert(subject, message) {
     logger.info(`Alert with subject: ${subject} message: ${message}`);
   }
 }

test/util/alertmanager.test.js

@@ -0,0 +1,21 @@
+const { describe, it, beforeEach } = require('mocha');
+const sinon = require('sinon');
+const { expect } = require('chai');
+const logger = require('../../lib/util/loggerFactory');
+const AlertManager = require('../../lib/util/AlertManager');
+
+describe('#AlertManager', () => {
+  let alertManager;
+  beforeEach(() => {
+    alertManager = new AlertManager();
+  });
+
+  describe('#sendAlert', () => {
+    it('should log & send alert', () => {
+      const loggerStub = sinon.stub(logger, 'info');
+      alertManager.sendAlert('SUBJECT', 'MESSAGE');
+      expect(loggerStub.calledOnce).to.be.equal(true);
+      loggerStub.restore();
+    });
+  });
+});

test/util/errorhandler.test.js

@@ -0,0 +1,33 @@
+const { describe, it, beforeEach } = require('mocha');
+const sinon = require('sinon');
+const { expect } = require('chai');
+const logger = require('../../lib/util/loggerFactory');
+const ErrorHandler = require('../../lib/util/ErrorHandler');
+const AlertManager = require('../../lib/util/AlertManager');
+
+describe('#ErrorHandler', () => {
+  let errorHandler;
+  beforeEach(() => {
+    errorHandler = new ErrorHandler(new AlertManager());
+  });
+
+  describe('#onError', () => {
+    it('should log global exception', () => {
+      const loggerStub = sinon.stub(logger, 'error');
+      errorHandler.onError({
+        stack: 'I am stacktrace!',
+      });
+      expect(loggerStub.calledOnce).to.be.equal(true);
+      loggerStub.restore();
+    });
+
+    it('should send alert', () => {
+      process.env.NODE_ENV = 'prod';
+      const loggerStub = sinon.stub(logger, 'error');
+      errorHandler.onError('I am error');
+      expect(loggerStub.calledOnce).to.be.equal(true);
+      loggerStub.restore();
+      process.env.NODE_ENV = 'test';
+    });
+  });
+});

test/util/instrumentation.test.js

@@ -4,7 +4,7 @@ const sinon = require('sinon');
 const { expect } = require('chai');
 const logger = require('../../lib/util/loggerFactory');
 
-describe('typeSanity', () => {
+describe('#Instrumentation', () => {
   let instrumentation;
   beforeEach(() => {
     instrumentation = new Instrumentation();