Small changes to the knob view

Author: brummer10

NeuralRack/clap/NeuralRack.cc

@@ -57,7 +57,6 @@ class NeuralRack
         fetch.stop();
         free(ui->private_ptr);
         free(ui);
-        //cleanup();
     }
 
     void startGui(Window window) {
@@ -545,6 +544,8 @@ class NeuralRack
 
     void cleanup() {
         plugin_cleanup(ui);
+        free(ui->private_ptr);
+        ui->private_ptr = NULL;
         // Xputty free all memory used
         // main_quit(&ui->main);
     }

NeuralRack/clap/NeuralRackClap.cpp

@@ -274,6 +274,7 @@ static bool neuralrack_gui_create(const clap_plugin *plugin, const char *api, bo
         if (!plug->guiIsCreated) {
             plug->r->startGui();
             plug->r->enableEngine(1);
+            fprintf(stderr, "createGui\n");
         }
         plug->guiIsCreated = true;
         return true;
@@ -283,6 +284,7 @@ static bool neuralrack_gui_create(const clap_plugin *plugin, const char *api, bo
 
 static void neuralrack_gui_destroy(const clap_plugin *plugin) {
     neuralrack_plugin_t *plug = (neuralrack_plugin_t *)plugin->plugin_data;
+    if (plug->guiIsCreated) plug->r->cleanup();
     plug->r->quitGui();
     plug->guiIsCreated = false;
 }

NeuralRack/gui/widgets.cc

@@ -494,7 +494,7 @@ void setKnobFrame(Widget_t* w, int x, int y, int wi, int h) {
     cairo_pattern_add_color_stop_rgba
         (pat, 0, c->bg[0]*4.5, c->bg[1]*4.5, c->bg[2]*4.5,1.0);
     cairo_pattern_add_color_stop_rgba
-        (pat, 0.2, c->bg[0]*3.0, c->bg[1]*3.0, c->bg[2]*4.0,1.0);
+        (pat, 0.2, c->bg[0]*3.0, c->bg[1]*3.0, c->bg[2]*3.0,1.0);
     cairo_pattern_add_color_stop_rgba
         (pat, 0.3, c->bg[0]*2.0, c->bg[1]*2.0, c->bg[2]*2.0,1.0);
     cairo_pattern_add_color_stop_rgba 
@@ -550,9 +550,9 @@ static void draw_my_knob(void *w_, void* user_data) {
         );
         cairo_pattern_add_color_stop_rgb(pat, 0.00, 0.33, 0.33, 0.33);
         cairo_pattern_add_color_stop_rgb(pat, 0.1, 0.20, 0.20, 0.20);
-        cairo_pattern_add_color_stop_rgb(pat, 0.30, 0.09, 0.09, 0.09);
-        cairo_pattern_add_color_stop_rgb(pat, 0.65, 0.03, 0.03, 0.03);
-        cairo_pattern_add_color_stop_rgb(pat, 1.00, 0.01, 0.01, 0.01);
+        cairo_pattern_add_color_stop_rgb(pat, 0.25, 0.09, 0.09, 0.09);
+        cairo_pattern_add_color_stop_rgb(pat, 0.65, 0.063, 0.063, 0.063);
+        cairo_pattern_add_color_stop_rgb(pat, 1.00, 0.033, 0.033, 0.033);
         cairo_set_source(w->crb, pat);
         cairo_fill_preserve(w->crb);
         cairo_pattern_destroy(pat);

NeuralRack/vst2/NeuralRackvst.cpp

@@ -43,6 +43,7 @@ struct neuralrack_plugin_t {
     float SampleRate;
     std::string state;
     bool isInited;
+    bool guiIsCreated;
 };
 
 /****************************************************************
@@ -139,11 +140,15 @@ static intptr_t dispatcher(AEffect* effect, int32_t opCode, int32_t index, intpt
             plug->r->enableEngine(1);
             plug->r->setParent(hostWin);
             plug->r->showGui();
+            plug->guiIsCreated = true;
             break;
         }
-        case effEditClose:
+        case effEditClose: {
+            if (plug->guiIsCreated) plug->r->cleanup();
             plug->r->quitGui();
+            plug->guiIsCreated = false;
             break;
+        }
         case effEditIdle:
             break;
         //case effGetProgram:
@@ -182,6 +187,7 @@ AEffect* VSTPluginMain(audioMasterCallback audioMaster) {
     plug->editorRect = {0, 0, (short) plug->height, (short) plug->width};
     plug->SampleRate = 48000.0;
     plug->isInited = false;
+    plug->guiIsCreated = false;
 
     effect->magic = kEffectMagic;
     effect->dispatcher = dispatcher;