Skip to content

Commit e8f7733

Browse files
committed
Fix issue #19 CLAP Parameters not remembered in Bitwig
1 parent 72174b3 commit e8f7733

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

NeuralRack/clap/NeuralRack.cc

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include <unistd.h>
1313
#include <signal.h>
1414

15-
#include <atomic>
1615
#include <iostream>
1716
#include <fstream>
1817
#include <cstring>
@@ -61,10 +60,10 @@ class NeuralRack
6160
void registerParameters() {
6261
// name group min, max, def, step value isStepped type
6362
param.registerParam("Buffered Mode", "Global", 0,2,0,1, (void*)&engine.buffered, true, Is_FLOAT);
64-
param.registerParam("Enable", "Global", 0,1,0,1, (void*)&engine.bypass, true, IS_UINT);
63+
param.registerParam("Enable", "Global", 0,1,1,1, (void*)&engine.bypass, true, IS_UINT);
6564

6665
param.registerParam("Gate Enable", "NoiseGate", 0,1,0,1, (void*)&engine.ngOnOff, true, IS_UINT);
67-
param.registerParam("Gate Thresh", "NoiseGate", 0.01, 0.31, 0.017, 0.001, (void*)&engine.ngate->threshold, false, Is_FLOAT);
66+
param.registerParam("Gate Thresh", "NoiseGate", 0.01,0.31,0.017,0.001, (void*)&engine.ngate->threshold, false, Is_FLOAT);
6867

6968
param.registerParam("Norm Slot A", "Pedal", 0,1,0,1, (void*)&engine.normSlotA, true, IS_INT);
7069
param.registerParam("Input Gain A", "Pedal", -20,20,0,0.1, (void*)&engine.inputGain, false, Is_FLOAT);
@@ -229,14 +228,16 @@ class NeuralRack
229228
engine.peq->fVslider3 = 0.0;
230229
engine.peq->fVslider4 = 0.0;
231230
engine.peq->fVslider5 = -20.0;
232-
engine.ngate->threshold = -0.017;
231+
engine.ngate->threshold = 0.017;
233232
engine.ngOnOff = 0;
234233
}
235234

236235
void initEngine(uint32_t rate, int32_t prio, int32_t policy) {
237236
engine.init(rate, prio, policy);
238237
initEQ();
239238
engine.bypass = 1;
239+
param.setParamDirty(1 , true);
240+
param.controllerChanged.store(true, std::memory_order_release);
240241
s_time = (1.0 / (double)rate) * 1000;
241242
}
242243

NeuralRack/gui/NeuralRack.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ void plugin_create_controller_widgets(X11_UI *ui, const char * plugin_uri) {
200200
set_widget_color(ui->widget[26], (Color_state)0, (Color_mod)1, 0.083, 0.083, 0.083, 1.0);
201201
widget_get_png(ui->widget[26], LDVAR(exit__png));
202202

203-
ui->widget[25] = add_lv2_knob (ui->widget[25], ui->elem[4], 31, "", ui, 510, 9, 60, 60); //Threshold
203+
ui->widget[25] = add_lv2_knob (ui->widget[25], ui->elem[4], 31, "", ui, 510, 10, 60, 60); //Threshold
204204
set_adjustment(ui->widget[25]->adj, 0.017, 0.017, 0.01, 0.31, 0.001, CL_CONTINUOS);
205205
// controller label colour
206206
set_widget_color(ui->widget[25], (Color_state)0, (Color_mod)0, 0.235, 0.215, 0.282, 1.0);

0 commit comments

Comments
 (0)