Skip to content
This repository was archived by the owner on Aug 1, 2021. It is now read-only.

Commit 61d07c3

Browse files
committed
Merge branch 'master' into dev
# Conflicts: # src/Backend/Jp.Domain/Validations/Client/ClientValidations.cs # src/Frontend/Jp.AdminUI/src/app/shared/layout/header/header.component.ts # src/Frontend/Jp.UI.SSO/jpProject_sso_log.txt # tests/JpProject.Domain.Tests/ClientTests/ClientCommandHandlerTests.cs # tests/JpProject.Domain.Tests/ClientTests/Fakers/EntityClientFaker.cs
2 parents 538f5a0 + f0a5e5f commit 61d07c3

File tree

6 files changed

+4
-9
lines changed

6 files changed

+4
-9
lines changed

src/Backend/Jp.Domain/Validations/Client/ClientValidations.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ protected void ValidateGrantType()
2121
private bool ValidateGrantCombination(ICollection<string> grantTypes, string message)
2222
{
2323

24-
2524
// would allow response_type downgrade attack from code to token
2625
if (DisallowGrantTypeCombination(GrantType.Implicit, GrantType.AuthorizationCode, grantTypes))
2726
{

src/Frontend/Jp.AdminUI/src/app/shared/layout/header/header.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { MenuService } from "@core/menu/menu.service";
99
import { Router } from "@angular/router";
1010
import { environment } from "@env/environment";
1111

12-
1312
@Component({
1413
selector: "app-header",
1514
templateUrl: "./header.component.html",

src/Frontend/Jp.UI.SSO/jpProject_sso_log.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17219,6 +17219,7 @@ Error Number:2714,State:6,Class:16
1721917219
2019-03-29 03:33:41.664 -03:00 [INF] Invoking IdentityServer endpoint: IdentityServer4.Endpoints.DiscoveryKeyEndpoint for /.well-known/openid-configuration/jwks
1722017220
2019-03-29 03:33:41.670 -03:00 [DBG] Start key discovery request
1722117221
2019-03-29 03:33:54.575 -03:00 [INF] Removing 0 grants
17222+
<<<<<<< HEAD
1722217223
2019-03-30 00:30:38.774 -03:00 [INF] SigninCredentialExtension keyType is Temporary
1722317224
2019-03-30 00:30:39.000 -03:00 [INF] SigninCredentialExtension added
1722417225
2019-03-30 00:30:43.548 -03:00 [INF] Starting IdentityServer4 version 2.4.0.0
@@ -17237,3 +17238,5 @@ Error Number:2714,State:6,Class:16
1723717238
2019-03-30 00:30:54.006 -03:00 [DBG] Error Url: /home/error
1723817239
2019-03-30 00:30:54.008 -03:00 [DBG] Error Id Parameter: errorId
1723917240
2019-03-30 00:30:58.872 -03:00 [INF] Removing 0 grants
17241+
=======
17242+
>>>>>>> remotes/origin/master

tests/JpProject.Domain.Tests/ClientTests/ClientCommandHandlerTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,5 @@ public async Task ShouldSaveClaim()
428428
Assert.False(result);
429429
}
430430

431-
432431
}
433432
}

tests/JpProject.Domain.Tests/ClientTests/Fakers/ClientFaker.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ public static Faker<Client> GenerateClient(
5151
.RuleFor(c => c.PairWiseSubjectSalt, f => f.Lorem.Word())
5252
.RuleFor(c => c.UserCodeType, f => f.Lorem.Word())
5353
.RuleFor(c => c.AllowedCorsOrigins, f => Enumerable.Range(1, f.Random.Int(1, 3)).Select(x => f.PickRandom(f.Internet.Url())).ToList())
54-
5554
.RuleFor(c => c.IdentityTokenLifetime, f => identityTokenLifetime ?? f.Random.Int(0))
5655
.RuleFor(c => c.AccessTokenLifetime, f => accessTokenLifetime ?? f.Random.Int(0))
5756
.RuleFor(c => c.AuthorizationCodeLifetime, f => authorizationCodeLifetime ?? f.Random.Int(0))

tests/JpProject.Domain.Tests/ClientTests/Fakers/EntityClientFaker.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,25 +41,20 @@ public static Faker<ClientIdPRestriction> GenerateClientIdPRestriction()
4141
.RuleFor(c => c.Provider, f => f.PickRandom(IdentityHelpers.Providers))
4242
.RuleFor(c => c.ClientId, f => f.Random.Int(0));
4343

44-
45-
4644
}
4745
public static Faker<ClientScope> GenerateClientScope()
4846
{
4947
return new Faker<ClientScope>()
5048
.RuleFor(c => c.Id, f => f.Random.Int(0))
5149
.RuleFor(c => c.Scope, f => f.PickRandom(IdentityHelpers.Scopes))
5250
.RuleFor(c => c.ClientId, f => f.Random.Int(0));
53-
54-
5551
}
5652
public static Faker<ClientPostLogoutRedirectUri> GenerateClientPostLogoutRedirectUri()
5753
{
5854
return new Faker<ClientPostLogoutRedirectUri>()
5955
.RuleFor(c => c.Id, f => f.Random.Int(0))
6056
.RuleFor(c => c.PostLogoutRedirectUri, f => f.Internet.Url())
6157
.RuleFor(c => c.ClientId, f => f.Random.Int(0));
62-
6358
}
6459

6560
public static Faker<ClientRedirectUri> GenerateClientRedirectUri()
@@ -142,6 +137,7 @@ public static Faker<Client> GenerateClient(
142137
.RuleFor(c => c.IdentityProviderRestrictions, f => GenerateClientIdPRestriction().Generate(f.Random.Int(0, 1)))
143138
.RuleFor(c => c.AllowedCorsOrigins, f => GenerateClientCorsOrigin().Generate(f.Random.Int(0, 2)))
144139
.RuleFor(c => c.Properties, f => GenerateClientProperty().Generate(clientProperties ?? f.Random.Int(0, 2)));
140+
145141
}
146142
}
147143
}

0 commit comments

Comments
 (0)