Skip to content
This repository was archived by the owner on Aug 1, 2021. It is now read-only.

Commit c9176a5

Browse files
Merge pull request #14 from brunohbrito/dev
bugs fix for google oauth
2 parents b1a451a + 38e9043 commit c9176a5

File tree

9 files changed

+21
-17553
lines changed

9 files changed

+21
-17553
lines changed

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,4 +247,7 @@ ModelManifest.xml
247247
# Sphinx
248248
*.opt
249249
docs/_build
250-
docs/.vscode
250+
docs/.vscode
251+
252+
# Log files
253+
**/*log*.txt

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
MIT License
22

3-
Copyright (c) 2016 Eduardo Pires
3+
Copyright (c) 2018 Bruno Brito
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

src/Backend/Jp.Infra.CrossCutting.IdentityServer/Configuration/SigninCredentialExtension.cs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public static class SigninCredentialExtension
2525

2626
private const string FileName = nameof(FileName);
2727
private const string FilePassword = nameof(FilePassword);
28-
private const string KeyStoreIssuer = nameof(KeyStoreIssuer);
28+
private const string CertificateThumbprint = nameof(CertificateThumbprint);
2929

3030
public static IIdentityServerBuilder AddSigninCredentialFromConfig(
3131
this IIdentityServerBuilder builder, IConfigurationSection options, ILogger logger, IHostingEnvironment env)
@@ -74,14 +74,18 @@ private static void AddCertificateFromEnvironment(IIdentityServerBuilder builder
7474
private static void AddCertificateFromStore(IIdentityServerBuilder builder,
7575
IConfigurationSection options, ILogger logger)
7676
{
77-
var keyIssuer = options.GetValue<string>(KeyStoreIssuer);
77+
var keyIssuer = options.GetValue<string>(CertificateThumbprint);
7878
logger.LogInformation($"SigninCredentialExtension adding key from store by {keyIssuer}");
7979

80-
X509Store store = new X509Store(StoreName.My, StoreLocation.LocalMachine);
80+
X509Store store = new X509Store(StoreName.My, StoreLocation.CurrentUser);
8181
store.Open(OpenFlags.ReadOnly);
8282

83-
var certificates = store.Certificates.Find(X509FindType.FindByIssuerName, keyIssuer, true);
84-
83+
var certificates = store.Certificates.Find(X509FindType.FindByThumbprint, keyIssuer, false);
84+
logger.LogInformation($"Certificates on store: {store.Certificates.Count}");
85+
foreach (var storeCertificate in store.Certificates)
86+
{
87+
logger.LogInformation($"{storeCertificate.Thumbprint} - {storeCertificate.IssuerName.Name}");
88+
}
8589
if (certificates.Count > 0)
8690
builder.AddSigningCredential(certificates[0]);
8791
else

src/Backend/Jp.UserManagement/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public static void Main(string[] args)
2121
.MinimumLevel.Override("Microsoft.AspNetCore.Authentication", LogEventLevel.Information)
2222
.Enrich.FromLogContext()
2323
.WriteTo.ApplicationInsights(TelemetryConfiguration.Active, TelemetryConverter.Traces)
24-
.WriteTo.File(@"jpProject_sso_log.txt")
24+
.WriteTo.File(@"jpProject_sso_log-.txt", rollingInterval: RollingInterval.Day, retainedFileCountLimit: 5)
2525
.WriteTo.Console()
2626
.CreateLogger();
2727

src/Frontend/Jp.UI.SSO/Configuration/SigninCredentialExtension.cs

Lines changed: 0 additions & 109 deletions
This file was deleted.

src/Frontend/Jp.UI.SSO/Configuration/SocialIntegrationConfig.cs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,8 @@ public static IServiceCollection AddAuth(this IServiceCollection services,
2727
{
2828
OnCreatingTicket = context =>
2929
{
30-
var identity = (ClaimsIdentity)context.Principal.Identity;
31-
var profileImg = context.User["image"].Value<string>("url");
32-
identity.AddClaim(new Claim(JwtClaimTypes.Picture, profileImg));
30+
if (context.User.ContainsKey("image"))
31+
context.Identity.AddClaim(new Claim(JwtClaimTypes.Picture, context.User.GetValue("image").SelectToken("url").ToString()));
3332
return Task.CompletedTask;
3433
}
3534
};
@@ -48,9 +47,8 @@ public static IServiceCollection AddAuth(this IServiceCollection services,
4847
{
4948
OnCreatingTicket = context =>
5049
{
51-
var identity = (ClaimsIdentity)context.Principal.Identity;
52-
var profileImg = context.User["picture"]["data"].Value<string>("url");
53-
identity.AddClaim(new Claim(JwtClaimTypes.Picture, profileImg));
50+
if (context.User.ContainsKey("picture"))
51+
context.Identity.AddClaim(new Claim(JwtClaimTypes.Picture, context.User.GetValue("picture").SelectToken("data").SelectToken("url").ToString()));
5452
return Task.CompletedTask;
5553
}
5654
};

src/Frontend/Jp.UI.SSO/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public static void Main(string[] args)
2424
.MinimumLevel.Override("Microsoft.AspNetCore.Authentication", LogEventLevel.Information)
2525
.Enrich.FromLogContext()
2626
.WriteTo.ApplicationInsights(TelemetryConfiguration.Active, TelemetryConverter.Traces)
27-
.WriteTo.File(@"jpProject_sso_log.txt")
27+
.WriteTo.File(@"jpProject_sso_log-.txt", rollingInterval: RollingInterval.Day, retainedFileCountLimit: 5)
2828
.WriteTo.Console(outputTemplate: "[{Timestamp:HH:mm:ss} {Level}] {SourceContext}{NewLine}{Message:lj}{NewLine}{Exception}{NewLine}", theme: AnsiConsoleTheme.Literate)
2929
.CreateLogger();
3030

src/Frontend/Jp.UI.SSO/appsettings.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
},
1010
"CertificateOptions": {
1111
"Type": "Temporary",
12+
"KeyStoreIssuer": null,
1213
"FileName": "jpproject.pfx",
1314
"FilePassword": ".pxCpE]yttwC&b&hriw#,7K^_}A7xezRH3=EisJKn3]8.H}^Unzd+ebw]zzv_=d3"
1415
},

0 commit comments

Comments
 (0)