fix: inheritance check

brunomikoski · brunomikoski · commit c1e47a8c83a7 · 2025-12-04T17:26:40.000-03:00
diff --git a/Scripts/Runtime/Core/CollectionsRegistry.cs b/Scripts/Runtime/Core/CollectionsRegistry.cs
@@ -224,17 +224,17 @@ public List<ScriptableObjectCollection> GetCollectionsByItemType(Type targetColl
 
             for (int i = 0; i < collections.Count; i++)
             {
-                ScriptableObjectCollection scriptableObjectCollection = collections[i];
-                if (targetCollectionItemType.IsAssignableFrom(scriptableObjectCollection.GetItemType()))
+                ScriptableObjectCollection col = collections[i];
+                Type collectionItemType = col.GetItemType();
+                if (collectionItemType != null && collectionItemType.IsAssignableFrom(targetCollectionItemType))
                 {
-                    result.Add(scriptableObjectCollection);
+                    result.Add(col);
                 }
             }
 
             return result;
         }
 
-
         [Obsolete("Use GetCollectionByGUID(ULongGuid guid) is obsolete, please regenerate your static class")]
         public ScriptableObjectCollection GetCollectionByGUID(string guid)
         {

Original file line number	Diff line number	Diff line change
`@@ -224,17 +224,17 @@ public List<ScriptableObjectCollection> GetCollectionsByItemType(Type targetColl`
`224`	`224`
`225`	`225`	`for (int i = 0; i < collections.Count; i++)`
`226`	`226`	`{`
`227`		`- ScriptableObjectCollection scriptableObjectCollection = collections[i];`
`228`		`- if (targetCollectionItemType.IsAssignableFrom(scriptableObjectCollection.GetItemType()))`
	`227`	`+ ScriptableObjectCollection col = collections[i];`
	`228`	`+ Type collectionItemType = col.GetItemType();`
	`229`	`+ if (collectionItemType != null && collectionItemType.IsAssignableFrom(targetCollectionItemType))`
`229`	`230`	`{`
`230`		`- result.Add(scriptableObjectCollection);`
	`231`	`+ result.Add(col);`
`231`	`232`	`}`
`232`	`233`	`}`
`233`	`234`
`234`	`235`	`return result;`
`235`	`236`	`}`
`236`	`237`
`237`		`-`
`238`	`238`	`[Obsolete("Use GetCollectionByGUID(ULongGuid guid) is obsolete, please regenerate your static class")]`
`239`	`239`	`public ScriptableObjectCollection GetCollectionByGUID(string guid)`
`240`	`240`	`{`