Skip to content

Commit 93c22f5

Browse files
committed
Address comments from terraform-google-modules#528
1 parent 7c69f8d commit 93c22f5

File tree

5 files changed

+2
-23
lines changed

5 files changed

+2
-23
lines changed

examples/backend-with-iap/outputs.tf

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@
1616

1717

1818
output "project_id" {
19-
value = module.lb-backend-iap.project_id
19+
value = var.project_id
2020
description = "Project ID of the service"
2121
}
22-
23-
output "service_name" {
24-
value = module.lb-backend-iap.service_name
25-
description = "Name of the created service"
26-
}

modules/backend/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,5 @@ This module creates `google_compute_backend_service` resource and its dependenci
4444
|------|-------------|
4545
| apphub\_service\_uri | Service URI in CAIS style to be used by Apphub. |
4646
| backend\_service\_info | Host, path and backend service mapping |
47-
| project\_id | Project ID of the service |
48-
| service\_name | Name of the created service |
4947

5048
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

modules/backend/metadata.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,10 +330,6 @@ spec:
330330
- backend_service: string
331331
host: string
332332
path: string
333-
- name: project_id
334-
description: Project ID of the service
335-
- name: service_name
336-
description: Name of the created service
337333
requirements:
338334
roles:
339335
- level: Project

modules/backend/outputs.tf

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,3 @@ output "apphub_service_uri" {
4343
)
4444
description = "Service URI in CAIS style to be used by Apphub."
4545
}
46-
47-
output "project_id" {
48-
value = var.project_id
49-
description = "Project ID of the service"
50-
}
51-
52-
output "service_name" {
53-
value = var.name
54-
description = "Name of the created service"
55-
}

test/integration/backend-with-iap/backend_with_iap_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func TestLbBackendServiceIap(t *testing.T) {
2929
backendServiceWithIAP.DefineVerify(func(assert *assert.Assertions) {
3030

3131
projectID := backendServiceWithIAP.GetTFSetupStringOutput("project_id")
32-
serviceName := backendServiceWithIAP.GetStringOutput("service_name")
32+
serviceName := "backend-with-iap"
3333

3434
backendServiceDescribeCmd := gcloud.Run(t, "compute backend-services describe", gcloud.WithCommonArgs([]string{serviceName, "--project", projectID, "--global", "--format", "json"}))
3535

0 commit comments

Comments
 (0)