Created a variable " this.envMapUniformName" to keep track of proper name for uniform across three js versions

I added a simple variable to keep track of the uniform's name across three js/A-Frame versions. This seemed like a quick and easy solution to me. I did some manual testing and I didn't encounter any problems. Everything should now work as intended in A-Frame versions 1.4.0 + : )

Author: AryehMischel

index.js

@@ -53,16 +53,27 @@ AFRAME.registerComponent("cubemap", {
       side: THREE.BackSide,
       transparent: true
     }).clone();
+    
+    //https://github.com/mrdoob/three.js/wiki/Migration-Guide#145--146
+    //they changed the name of the uniform from tCube to envMap, this variable helps us keep track of the name across three js versions
+    this.envMapUniformName = this.material.uniforms["envMap"] ? "envMap" : "tCube";
+  
+
     // Threejs seems to have removed the 'tCube' uniform.
     // Workaround from: https://stackoverflow.com/a/59454999/6591491
+    
     Object.defineProperty(this.material, "envMap", {
       get: function () {
-        return this.uniforms.envMap.value;
+          return this.uniforms.envMap ? this.uniforms.envMap.value : this.uniforms.tCube.value;
       },
     });
+
     // A dummy texture is needed (otherwise the shader will be invalid and spew
     // a million errors)
-    this.material.uniforms["envMap"].value = new THREE.Texture();
+    
+  //   this.material.uniforms["envMap"].value = new THREE.Texture();
+    this.material.uniforms[this.envMapUniformName].value = new THREE.Texture();
+
     this.loader = new THREE.CubeTextureLoader();
 
     // We can create the mesh now and update the material with a texture later on
@@ -135,8 +146,8 @@ AFRAME.registerComponent("cubemap", {
         rendererSystem.applyColorCorrection(texture);
 
         // Apply cubemap texture to shader uniforms and dispose of the old texture.
-        const oldTexture = this.material.uniforms["envMap"].value;
-        this.material.uniforms["envMap"].value = texture;
+        const oldTexture = this.material.uniforms[this.envMapUniformName].value;
+        this.material.uniforms[this.envMapUniformName].value = texture;
         if (oldTexture) {
           oldTexture.dispose();
         }
@@ -153,8 +164,8 @@ AFRAME.registerComponent("cubemap", {
    */
   remove: function () {
     this.geometry.dispose();
-    this.material.uniforms["envMap"].value.dispose();
+    this.material.uniforms[this.envMapUniformName].value.dispose();
     this.material.dispose();
     this.el.removeObject3D("cubemap");
   },
-});
+});