Only load relations as needed

[lourd]

Hello, great library! I've been evaluating it and had a question about using the hasMany helper function. If you specify that a BookshelfType hasMany of something else, it looks like here in the code that it loads the relation as a second query. Is that correct?

Also, instead of using this.constructor.collection to call the static method on L31 I believe you could use BookshelfType.collection

[brysgo]

Pull requests are welcome!!

[lourd]

=) good to know! I'll make one for the static .collection call change soon.

What are your thoughts on my first point, does the library eagerly load all first-order relations?

[brysgo]

I'd have to read the code to remind myself, it wasn't written for performance, but I'd love to tune it up as needed.

[tmack8001]

I started using this library today and noticed and thought about this same thing.

With enabling debug mode on my knex setup config I see the following queries when loading a .hasMany relationship.

{ method: 'select', options: {}, bindings: [ '6', 1 ],
sql: 'select "students".* from "students" where "id" = ? limit ?' }
{ method: 'select', options: {}, bindings: [ '6' ],
sql: 'select "homeworks".* from "homeworks" where "homeworks"."student_id" in (?)' }

[brysgo]

@tmack8001 This is where batching would come in, shouldn't be too difficult to add in. I misunderstood, if you were only loading a single relationship then that shouldn't happen. That is something we should be able to fix.

[brysgo]

@lourd - on the collection change, if you think that would be easier to read, make the change