Merge pull request #8 from bsayli/feature/response-modernization

Feature: Modernize API response architecture with RFC 7807 and generics-aware pagination

Author: bsayli

README.md

@@ -6,7 +6,7 @@
 
     <groupId>io.github.bsayli</groupId>
     <artifactId>customer-service-client</artifactId>
-    <version>0.6.8</version>
+    <version>0.7.0</version>
     <name>customer-service-client</name>
     <description>Generated client (RestClient) using generics-aware OpenAPI templates</description>
     <packaging>jar</packaging>

customer-service-client/README.md

@@ -1,16 +1,31 @@
 package io.github.bsayli.openapi.client.adapter;
 
+import io.github.bsayli.openapi.client.common.Page;
 import io.github.bsayli.openapi.client.common.ServiceClientResponse;
-import io.github.bsayli.openapi.client.generated.dto.*;
+import io.github.bsayli.openapi.client.common.sort.SortDirection;
+import io.github.bsayli.openapi.client.common.sort.SortField;
+import io.github.bsayli.openapi.client.generated.dto.CustomerCreateRequest;
+import io.github.bsayli.openapi.client.generated.dto.CustomerDeleteResponse;
+import io.github.bsayli.openapi.client.generated.dto.CustomerDto;
+import io.github.bsayli.openapi.client.generated.dto.CustomerUpdateRequest;
 
 public interface CustomerClientAdapter {
-  ServiceClientResponse<CustomerCreateResponse> createCustomer(CustomerCreateRequest request);
+
+  ServiceClientResponse<CustomerDto> createCustomer(CustomerCreateRequest request);
 
   ServiceClientResponse<CustomerDto> getCustomer(Integer customerId);
 
-  ServiceClientResponse<CustomerListResponse> getCustomers();
+  ServiceClientResponse<Page<CustomerDto>> getCustomers();
+
+  ServiceClientResponse<Page<CustomerDto>> getCustomers(
+      String name,
+      String email,
+      Integer page,
+      Integer size,
+      SortField sortBy,
+      SortDirection direction);
 
-  ServiceClientResponse<CustomerUpdateResponse> updateCustomer(
+  ServiceClientResponse<CustomerDto> updateCustomer(
       Integer customerId, CustomerUpdateRequest request);
 
   ServiceClientResponse<CustomerDeleteResponse> deleteCustomer(Integer customerId);

customer-service-client/pom.xml

@@ -1,20 +1,41 @@
 package io.github.bsayli.openapi.client.adapter.config;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
+import io.github.bsayli.openapi.client.common.error.ClientProblemException;
 import io.github.bsayli.openapi.client.generated.api.CustomerControllerApi;
+import io.github.bsayli.openapi.client.generated.dto.ProblemDetail;
 import io.github.bsayli.openapi.client.generated.invoker.ApiClient;
 import java.time.Duration;
+import java.util.List;
 import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
 import org.apache.hc.client5.http.impl.classic.HttpClients;
 import org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManagerBuilder;
 import org.springframework.beans.factory.annotation.Value;
+import org.springframework.boot.web.client.RestClientCustomizer;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
+import org.springframework.http.HttpStatusCode;
 import org.springframework.http.client.HttpComponentsClientHttpRequestFactory;
 import org.springframework.web.client.RestClient;
 
 @Configuration
 public class CustomerApiClientConfig {
 
+  @Bean
+  RestClientCustomizer problemDetailStatusHandler(ObjectMapper om) {
+    return builder ->
+        builder.defaultStatusHandler(
+            HttpStatusCode::isError,
+            (request, response) -> {
+              ProblemDetail pd = null;
+              try (var is = response.getBody()) {
+                pd = om.readValue(is, ProblemDetail.class);
+              } catch (Exception ignore) {
+              }
+              throw new ClientProblemException(pd, response.getStatusCode().value());
+            });
+  }
+
   @Bean(destroyMethod = "close")
   CloseableHttpClient customerHttpClient(
       @Value("${customer.api.max-connections-total:64}") int maxTotal,
@@ -51,8 +72,14 @@ HttpComponentsClientHttpRequestFactory customerRequestFactory(
 
   @Bean
   RestClient customerRestClient(
-      RestClient.Builder builder, HttpComponentsClientHttpRequestFactory customerRequestFactory) {
-    return builder.requestFactory(customerRequestFactory).build();
+      RestClient.Builder builder,
+      HttpComponentsClientHttpRequestFactory customerRequestFactory,
+      List<RestClientCustomizer> customizers) {
+    builder.requestFactory(customerRequestFactory);
+    if (customizers != null) {
+      customizers.forEach(c -> c.customize(builder));
+    }
+    return builder.build();
   }
 
   @Bean

customer-service-client/src/main/java/io/github/bsayli/openapi/client/adapter/CustomerClientAdapter.java

@@ -1,50 +1,64 @@
 package io.github.bsayli.openapi.client.adapter.impl;
 
 import io.github.bsayli.openapi.client.adapter.CustomerClientAdapter;
+import io.github.bsayli.openapi.client.common.Page;
 import io.github.bsayli.openapi.client.common.ServiceClientResponse;
+import io.github.bsayli.openapi.client.common.sort.SortDirection;
+import io.github.bsayli.openapi.client.common.sort.SortField;
 import io.github.bsayli.openapi.client.generated.api.CustomerControllerApi;
-import io.github.bsayli.openapi.client.generated.dto.CustomerCreateRequest;
-import io.github.bsayli.openapi.client.generated.dto.CustomerCreateResponse;
-import io.github.bsayli.openapi.client.generated.dto.CustomerDeleteResponse;
-import io.github.bsayli.openapi.client.generated.dto.CustomerDto;
-import io.github.bsayli.openapi.client.generated.dto.CustomerListResponse;
-import io.github.bsayli.openapi.client.generated.dto.CustomerUpdateRequest;
-import io.github.bsayli.openapi.client.generated.dto.CustomerUpdateResponse;
+import io.github.bsayli.openapi.client.generated.dto.*;
 import org.springframework.stereotype.Service;
 
 @Service
 public class CustomerClientAdapterImpl implements CustomerClientAdapter {
 
-  private final CustomerControllerApi customerControllerApi;
+  private final CustomerControllerApi api;
 
   public CustomerClientAdapterImpl(CustomerControllerApi customerControllerApi) {
-    this.customerControllerApi = customerControllerApi;
+    this.api = customerControllerApi;
   }
 
   @Override
-  public ServiceClientResponse<CustomerCreateResponse> createCustomer(
-      CustomerCreateRequest request) {
-    return customerControllerApi.createCustomer(request);
+  public ServiceClientResponse<CustomerDto> createCustomer(CustomerCreateRequest request) {
+    return api.createCustomer(request);
   }
 
   @Override
   public ServiceClientResponse<CustomerDto> getCustomer(Integer customerId) {
-    return customerControllerApi.getCustomer(customerId);
+    return api.getCustomer(customerId);
   }
 
   @Override
-  public ServiceClientResponse<CustomerListResponse> getCustomers() {
-    return customerControllerApi.getCustomers();
+  public ServiceClientResponse<Page<CustomerDto>> getCustomers() {
+    return getCustomers(null, null, 0, 5, SortField.CUSTOMER_ID, SortDirection.ASC);
   }
 
   @Override
-  public ServiceClientResponse<CustomerUpdateResponse> updateCustomer(
+  public ServiceClientResponse<Page<CustomerDto>> getCustomers(
+      String name,
+      String email,
+      Integer page,
+      Integer size,
+      SortField sortBy,
+      SortDirection direction) {
+
+    return api.getCustomers(
+        name,
+        email,
+        page,
+        size,
+        sortBy != null ? sortBy.value() : SortField.CUSTOMER_ID.value(),
+        direction != null ? direction.value() : SortDirection.ASC.value());
+  }
+
+  @Override
+  public ServiceClientResponse<CustomerDto> updateCustomer(
       Integer customerId, CustomerUpdateRequest request) {
-    return customerControllerApi.updateCustomer(customerId, request);
+    return api.updateCustomer(customerId, request);
   }
 
   @Override
   public ServiceClientResponse<CustomerDeleteResponse> deleteCustomer(Integer customerId) {
-    return customerControllerApi.deleteCustomer(customerId);
+    return api.deleteCustomer(customerId);
   }
 }

customer-service-client/src/main/java/io/github/bsayli/openapi/client/adapter/config/CustomerApiClientConfig.java

@@ -0,0 +1,11 @@
+package io.github.bsayli.openapi.client.common;
+
+import io.github.bsayli.openapi.client.common.sort.ClientSort;
+import java.time.Instant;
+import java.util.List;
+
+public record ClientMeta(Instant serverTime, List<ClientSort> sort) {
+  public ClientMeta {
+    sort = (sort == null) ? List.of() : List.copyOf(sort);
+  }
+}

customer-service-client/src/main/java/io/github/bsayli/openapi/client/adapter/impl/CustomerClientAdapterImpl.java

@@ -0,0 +1,17 @@
+package io.github.bsayli.openapi.client.common;
+
+import java.util.List;
+
+public record Page<T>(
+    List<T> content,
+    int page,
+    int size,
+    long totalElements,
+    int totalPages,
+    boolean hasNext,
+    boolean hasPrev) {
+
+  public Page {
+    content = (content == null) ? List.of() : List.copyOf(content);
+  }
+}

customer-service-client/src/main/java/io/github/bsayli/openapi/client/common/ClientErrorDetail.java

@@ -1,52 +1,21 @@
 package io.github.bsayli.openapi.client.common;
 
-import java.util.List;
 import java.util.Objects;
 
 public class ServiceClientResponse<T> {
 
-  private Integer status;
-  private String message;
-  private List<ClientErrorDetail> errors;
   private T data;
+  private ClientMeta meta;
 
   public ServiceClientResponse() {}
 
-  public ServiceClientResponse(
-      Integer status, String message, List<ClientErrorDetail> errors, T data) {
-    this.status = status;
-    this.message = message;
-    this.errors = errors;
+  public ServiceClientResponse(T data, ClientMeta meta) {
     this.data = data;
+    this.meta = meta;
   }
 
-  public static <T> ServiceClientResponse<T> from(
-      Integer status, String message, List<ClientErrorDetail> errors, T data) {
-    return new ServiceClientResponse<>(status, message, errors, data);
-  }
-
-  public Integer getStatus() {
-    return status;
-  }
-
-  public void setStatus(Integer status) {
-    this.status = status;
-  }
-
-  public String getMessage() {
-    return message;
-  }
-
-  public void setMessage(String message) {
-    this.message = message;
-  }
-
-  public List<ClientErrorDetail> getErrors() {
-    return errors;
-  }
-
-  public void setErrors(List<ClientErrorDetail> errors) {
-    this.errors = errors;
+  public static <T> ServiceClientResponse<T> of(T data, ClientMeta meta) {
+    return new ServiceClientResponse<>(data, meta);
   }
 
   public T getData() {
@@ -57,33 +26,28 @@ public void setData(T data) {
     this.data = data;
   }
 
+  public ClientMeta getMeta() {
+    return meta;
+  }
+
+  public void setMeta(ClientMeta meta) {
+    this.meta = meta;
+  }
+
   @Override
   public boolean equals(Object o) {
     if (this == o) return true;
     if (!(o instanceof ServiceClientResponse<?> that)) return false;
-    return Objects.equals(status, that.status)
-        && Objects.equals(message, that.message)
-        && Objects.equals(errors, that.errors)
-        && Objects.equals(data, that.data);
+    return Objects.equals(data, that.data) && Objects.equals(meta, that.meta);
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(status, message, errors, data);
+    return Objects.hash(data, meta);
   }
 
   @Override
   public String toString() {
-    return "ServiceClientResponse{"
-        + "status="
-        + status
-        + ", message='"
-        + message
-        + '\''
-        + ", errors="
-        + errors
-        + ", data="
-        + data
-        + '}';
+    return "ServiceClientResponse{data=" + data + ", meta=" + meta + '}';
   }
 }