add outputchannel

Author: bschnurr

.vscode/launch.json

@@ -1,22 +1,22 @@
-# Install Python on Linux
-
-To install the latest version of Python on [Debian-based Linux distributions](https://www.debian.org/), you can create a new terminal (<kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>`</kbd>) and run the following commands:
-
-
-```
-sudo apt-get update
-sudo apt-get install python3 python3-venv python3-pip
-```
-
-For [Fedora-based Linux distributions](https://getfedora.org/), you can run the following:
-
-```
-sudo dnf install python3
-```
-
-To verify if Python was successfully installed, run the following command in the terminal:
-
-
-```
-python3 --version
-```
+# Install Python on Linux
+
+To install the latest version of Python on [Debian-based Linux distributions](https://www.debian.org/), you can create a new terminal (<kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>`</kbd>) and run the following commands:
+
+
+```
+sudo apt-get update
+sudo apt-get install python3 python3-venv python3-pip
+```
+
+For [Fedora-based Linux distributions](https://getfedora.org/), you can run the following:
+
+```
+sudo dnf install python3
+```
+
+To verify if Python was successfully installed, run the following command in the terminal:
+
+
+```
+python3 --version
+```

resources/walkthrough/install-python-linux.md

@@ -1,15 +1,15 @@
-# Install Python on macOS
-
-If you have [Homebrew](https://brew.sh/) installed, you can install Python by running the following command in the terminal (<kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>`</kbd>):
-
-```
-brew install python3
-```
-
-If you don't have Homebrew, you can download a Python installer for macOS from [python.org](https://www.python.org/downloads/mac-osx/).
-
-To verify if Python was successfully installed, run the following command in the terminal:
-
-```
-python3 --version
-```
+# Install Python on macOS
+
+If you have [Homebrew](https://brew.sh/) installed, you can install Python by running the following command in the terminal (<kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>`</kbd>):
+
+```
+brew install python3
+```
+
+If you don't have Homebrew, you can download a Python installer for macOS from [python.org](https://www.python.org/downloads/mac-osx/).
+
+To verify if Python was successfully installed, run the following command in the terminal:
+
+```
+python3 --version
+```

resources/walkthrough/install-python-macos.md

@@ -145,6 +145,7 @@ export function buildApi(
             },
         },
         pylance: {
+            getOutputChannel: () => outputChannel.channel,
             createClient: (...args: any[]): BaseLanguageClient => {
                 // Make sure we share output channel so that we can share one with
                 // Jedi as well.

src/client/api.ts

@@ -7,6 +7,7 @@ import { BaseLanguageClient } from 'vscode-languageclient';
 import { LanguageClient } from 'vscode-languageclient/browser';
 import { PYTHON_LANGUAGE } from '../common/constants';
 import { ApiForPylance, TelemetryReporter } from '../pylanceApi';
+import { LogOutputChannel } from 'vscode';
 
 export interface IBrowserExtensionApi {
     /**
@@ -16,12 +17,14 @@ export interface IBrowserExtensionApi {
     pylance: ApiForPylance;
 }
 
-export function buildApi(reporter: TelemetryReporter): IBrowserExtensionApi {
+export function buildApi(reporter: TelemetryReporter, outputChannel: LogOutputChannel): IBrowserExtensionApi {
     const api: IBrowserExtensionApi = {
         pylance: {
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            // deprecated
             createClient: (...args: any[]): BaseLanguageClient =>
                 new LanguageClient(PYTHON_LANGUAGE, 'Python Language Server', args[0], args[1]),
+            getOutputChannel: () => outputChannel,
             start: (client: BaseLanguageClient): Promise<void> => client.start(),
             stop: (client: BaseLanguageClient): Promise<void> => client.stop(),
             getTelemetryReporter: () => reporter,

src/client/browser/api.ts

@@ -12,6 +12,7 @@ import { EventName } from '../telemetry/constants';
 import { createStatusItem } from './intellisenseStatus';
 import { PylanceApi } from '../activation/node/pylanceApi';
 import { buildApi, IBrowserExtensionApi } from './api';
+import { OutputChannelNames } from '../common/utils/localize';
 
 interface BrowserConfig {
     distUrl: string; // URL to Pylance's dist folder.
@@ -23,7 +24,8 @@ let pylanceApi: PylanceApi | undefined;
 export function activate(context: vscode.ExtensionContext): Promise<IBrowserExtensionApi> {
     const reporter = getTelemetryReporter();
 
-    const activationPromise = Promise.resolve(buildApi(reporter));
+    const outputChannel = vscode.window.createOutputChannel(OutputChannelNames.python, { log: true });
+    const activationPromise = Promise.resolve(buildApi(reporter, outputChannel));
     const pylanceExtension = vscode.extensions.getExtension<PylanceApi>(PYLANCE_EXTENSION_ID);
     if (pylanceExtension) {
         // Make sure we run pylance once we activated core extension.