Mark needless return(bla) with a macro so we can shut up FlexeLint

Author: bsdphk

ntimed_tricks.h

@@ -85,6 +85,15 @@
  */
 #define __match_proto__(xxx)		/*lint -e{818} */
 
+/*
+ * Some functions never return, and there's nothing Turing can do about it.
+ * Some compilers think you should still include a final return(bla) in
+ * such functions, while other tools complain about unreachable code.
+ * Wrapping in a macro means we can shut the tools up.
+ */
+
+#define NEEDLESS_RETURN(foo)	return(foo)
+
 /**********************************************************************
  * Compiler tricks
  */

ocx_stdio.c

@@ -79,7 +79,7 @@ getdst(enum ocx_chan chan)
 	if (chan == OCX_DEBUG)
 		return (stdout);
 	WRONG("Wrong ocx_chan");
-	return (NULL);
+	NEEDLESS_RETURN(NULL);
 }
 
 static void __match_proto__()

time_stuff.c

@@ -167,7 +167,7 @@ tb_Now(struct timestamp *storage)
 
 	(void)storage;
 	WRONG("No TB_Now");
-	return (NULL);
+	NEEDLESS_RETURN(NULL);
 }
 
 tb_now_f *TB_Now = tb_Now;
@@ -179,7 +179,7 @@ tb_Sleep(double dur)
 {
 	(void)dur;
 	WRONG("No TB_Sleep");
-	return (-1);
+	NEEDLESS_RETURN(-1);
 }
 
 tb_sleep_f *TB_Sleep = tb_Sleep;

udp.c

@@ -199,5 +199,5 @@ Udp_Send(struct ocx *ocx, const struct udp_socket *usc,
 		return (sendto(usc->fd6, buf, len, 0, ss, sl));
 
 	WRONG("Wrong AF_");
-	return (0);
+	NEEDLESS_RETURN(0);
 }